-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune #Bottom states when branching #3650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change LGTM.
Re-ran the integration test in CI 🤞
@@ -11,7 +11,6 @@ constraints: any.Cabal ==3.6.3.0, | |||
aeson -cffi +ordered-keymap, | |||
any.aeson-pretty ==0.8.9, | |||
aeson-pretty -lib-only, | |||
any.alex ==3.2.7.4, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, why would you like to remove those dependencies?
Maybe we should adapt the scripts that check or re-freeze if we need to remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have already removed these from the booster. they should not be fixed because the nix version of cabal comes with a different version of alex and happy and cant figure out a build plan using these
That did not work, though...
|
@goodlyrottenapple @geo2a I've also addressed this issue by pruning the |
Fix for change introduced by #3637, wherein branching could contain bottom states which were not being pruned. (see runtimeverification/pyk#634 (comment))