fix: make SimpleMessageQueue server cancellable #394
+28
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logan-markewich
approved these changes
Nov 29, 2024
It would work anyways, but I'd say, unless the lifespan is needed for also other purposes, keeping the cancelling logic close to the "server launch" logic is easier to maintain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several services don't shutdown properly, and while this is not a problem when you tear down the whole process, it's becoming an issue while we start moving towards a more distributed architecture, where services are expected to come and go (think of orchestrators).
This PR makes
SimpleMessageQueue.launch_server()cancellable, more to come.