Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variables to deployment definition #321

Open
masci opened this issue Oct 15, 2024 · 0 comments
Open

Add environment variables to deployment definition #321

masci opened this issue Oct 15, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request topic:apiserver

Comments

@masci
Copy link
Member

masci commented Oct 15, 2024

At the moment the only way to pass env vars to a running instance of Llama Deploy is through setting them before starting the process, which is not practical in case of a remote installation or docker containers.

We should add the option to declare the environment variables needed by each service like this:

services:
  test-workflow:
    name: Test Workflow
    env:
        OPENAI_API_KEY: "secret!"
    source:
      type: git
      name: https://github.com/run-llama/llama_deploy.git
    path: tests/apiserver/data/workflow:my_workflow

then the Control plane would propagate the env var when spinning up the service.

@masci masci added the enhancement New feature or request label Oct 15, 2024
@masci masci changed the title Add environment variables in deployment definition Add environment variables to deployment definition Oct 15, 2024
@nerdai nerdai self-assigned this Nov 29, 2024
@nerdai nerdai added this to Framework Nov 29, 2024
@nerdai nerdai moved this to In Progress in Framework Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic:apiserver
Projects
Status: In Progress
Development

No branches or pull requests

2 participants