Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error on riscv64 (#222) #232

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Fix build error on riscv64 (#222) #232

merged 1 commit into from
Jan 3, 2022

Conversation

OctopusET
Copy link
Contributor

Patch from this PR: uxlfoundation/oneTBB#550
Thank you, @felixonmars

Build works with this patch, but does not support elf64lriscv. So, test fails.

Fix: #222

@OctopusET
Copy link
Contributor Author

Tested with make test on x86_64 system(with docker), and passed every test.

@OctopusET
Copy link
Contributor Author

Changed Makefile to use -latomic flag only for RV64

@rui314
Copy link
Owner

rui314 commented Jan 3, 2022

Thanks! Can you read https://github.com/rui314/mold/blob/main/CONTRIBUTING.md and add a signed-off-by line to your commit message? Other than that, LGTM.

@OctopusET
Fix build error on riscv64 (#222)
3fb5416 
Patch from this PR: uxlfoundation/oneTBB#550

Signed-off-by: Moon Sungjoon <[email protected]>
@OctopusET
Copy link
Contributor Author

@rui314 Oh my bad, I added signed-off-by

Thanks!

@rui314 rui314 merged commit 4033b53 into rui314:main Jan 3, 2022
@rui314
Copy link
Owner

rui314 commented Jan 3, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build error on RISC-V 64bits system
2 participants
@OctopusET @rui314