fix(js): Switch to protocol-relative URL #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't have a hard-coded reference to http in 2019. That's no good. And I suspect that just swapping over to `https` will give people consternation. So, use a [protocol-relative url](https://www.paulirish.com/2010/the-protocol-relative-url/), and let the user's location decide. Should be fine.
|
@mlissner just to check i assume you've tested this yourself with your own buckets? |
|
Welp, it's been several months and now I don't remember, sorry. |
|
Now conflicts so closing as wontfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't have a hard-coded reference to http in 2019. That's no good. And I suspect that just swapping over to
httpswill give people consternation. So, use a protocol-relative url, and let the user's location decide. Should be fine.Fixes #82.