From f5a98757f8ad1ea6a7725c78560415c1161b89b7 Mon Sep 17 00:00:00 2001
From: Vinay Teki <vinayteki95@gmail.com>
Date: Wed, 14 Aug 2024 11:19:04 +0530
Subject: [PATCH 1/2] fix: update facebook_marketing version to v20.0 and made
 schema changes - breaking change

---
 .../source-facebook-marketing/setup.py        |   2 +-
 .../schemas/ads_insights.json                 |  24 --
 .../ads_insights_deprecated_after_v18.0.json  | 342 ++++++++++++++++++
 3 files changed, 343 insertions(+), 25 deletions(-)
 create mode 100644 airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ads_insights_deprecated_after_v18.0.json

diff --git a/airbyte-integrations/connectors/source-facebook-marketing/setup.py b/airbyte-integrations/connectors/source-facebook-marketing/setup.py
index f5ee54475344..45102391dbb5 100644
--- a/airbyte-integrations/connectors/source-facebook-marketing/setup.py
+++ b/airbyte-integrations/connectors/source-facebook-marketing/setup.py
@@ -8,7 +8,7 @@
 MAIN_REQUIREMENTS = [
     "airbyte-cdk==0.67",
     "cached_property==1.5.2",
-    "facebook_business==18.0.5",
+    "facebook_business==20.0.0",
     "pendulum>=2,<3",
 ]
 
diff --git a/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ads_insights.json b/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ads_insights.json
index 1428e2963307..2d4e40d41fd2 100644
--- a/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ads_insights.json
+++ b/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ads_insights.json
@@ -33,9 +33,6 @@
     "adset_name": {
       "type": ["null", "string"]
     },
-    "age_targeting": {
-      "type": ["null", "string"]
-    },
     "attribution_setting": {
       "type": ["null", "string"]
     },
@@ -168,21 +165,9 @@
     "estimated_ad_recall_rate": {
       "type": ["null", "number"]
     },
-    "estimated_ad_recall_rate_lower_bound": {
-      "type": ["null", "number"]
-    },
-    "estimated_ad_recall_rate_upper_bound": {
-      "type": ["null", "number"]
-    },
     "estimated_ad_recallers": {
       "type": ["null", "number"]
     },
-    "estimated_ad_recallers_lower_bound": {
-      "type": ["null", "number"]
-    },
-    "estimated_ad_recallers_upper_bound": {
-      "type": ["null", "number"]
-    },
     "frequency": {
       "type": ["null", "number"]
     },
@@ -192,9 +177,6 @@
     "full_view_reach": {
       "type": ["null", "number"]
     },
-    "gender_targeting": {
-      "type": ["null", "string"]
-    },
     "impressions": {
       "type": ["null", "integer"]
     },
@@ -216,12 +198,6 @@
     "instant_experience_outbound_clicks": {
       "$ref": "ads_action_stats.json"
     },
-    "labels": {
-      "type": ["null", "string"]
-    },
-    "location": {
-      "type": ["null", "string"]
-    },
     "mobile_app_purchase_roas": {
       "$ref": "ads_action_stats.json"
     },
diff --git a/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ads_insights_deprecated_after_v18.0.json b/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ads_insights_deprecated_after_v18.0.json
new file mode 100644
index 000000000000..1428e2963307
--- /dev/null
+++ b/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ads_insights_deprecated_after_v18.0.json
@@ -0,0 +1,342 @@
+{
+  "properties": {
+    "account_currency": {
+      "type": ["null", "string"]
+    },
+    "account_id": {
+      "type": ["null", "string"]
+    },
+    "account_name": {
+      "type": ["null", "string"]
+    },
+    "action_values": {
+      "$ref": "ads_action_stats.json"
+    },
+    "actions": {
+      "$ref": "ads_action_stats.json"
+    },
+    "ad_click_actions": {
+      "$ref": "ads_action_stats.json"
+    },
+    "ad_id": {
+      "type": ["null", "string"]
+    },
+    "ad_impression_actions": {
+      "$ref": "ads_action_stats.json"
+    },
+    "ad_name": {
+      "type": ["null", "string"]
+    },
+    "adset_id": {
+      "type": ["null", "string"]
+    },
+    "adset_name": {
+      "type": ["null", "string"]
+    },
+    "age_targeting": {
+      "type": ["null", "string"]
+    },
+    "attribution_setting": {
+      "type": ["null", "string"]
+    },
+    "auction_bid": {
+      "type": ["null", "number"]
+    },
+    "auction_competitiveness": {
+      "type": ["null", "number"]
+    },
+    "auction_max_competitor_bid": {
+      "type": ["null", "number"]
+    },
+    "buying_type": {
+      "type": ["null", "string"]
+    },
+    "campaign_id": {
+      "type": ["null", "string"]
+    },
+    "campaign_name": {
+      "type": ["null", "string"]
+    },
+    "canvas_avg_view_percent": {
+      "type": ["null", "number"]
+    },
+    "canvas_avg_view_time": {
+      "type": ["null", "number"]
+    },
+    "catalog_segment_actions": {
+      "$ref": "ads_action_stats.json"
+    },
+    "catalog_segment_value": {
+      "$ref": "ads_action_stats.json"
+    },
+    "catalog_segment_value_mobile_purchase_roas": {
+      "$ref": "ads_action_stats.json"
+    },
+    "catalog_segment_value_omni_purchase_roas": {
+      "$ref": "ads_action_stats.json"
+    },
+    "catalog_segment_value_website_purchase_roas": {
+      "$ref": "ads_action_stats.json"
+    },
+    "clicks": {
+      "type": ["null", "integer"]
+    },
+    "conversion_rate_ranking": {
+      "type": ["null", "string"]
+    },
+    "conversion_values": {
+      "$ref": "ads_action_stats.json"
+    },
+    "conversions": {
+      "$ref": "ads_action_stats.json"
+    },
+    "converted_product_quantity": {
+      "$ref": "ads_action_stats.json"
+    },
+    "converted_product_value": {
+      "$ref": "ads_action_stats.json"
+    },
+    "cost_per_15_sec_video_view": {
+      "$ref": "ads_action_stats.json"
+    },
+    "cost_per_2_sec_continuous_video_view": {
+      "$ref": "ads_action_stats.json"
+    },
+    "cost_per_action_type": {
+      "$ref": "ads_action_stats.json"
+    },
+    "cost_per_ad_click": {
+      "$ref": "ads_action_stats.json"
+    },
+    "cost_per_conversion": {
+      "$ref": "ads_action_stats.json"
+    },
+    "cost_per_estimated_ad_recallers": {
+      "type": ["null", "number"]
+    },
+    "cost_per_inline_link_click": {
+      "type": ["null", "number"]
+    },
+    "cost_per_inline_post_engagement": {
+      "type": ["null", "number"]
+    },
+    "cost_per_outbound_click": {
+      "$ref": "ads_action_stats.json"
+    },
+    "cost_per_thruplay": {
+      "$ref": "ads_action_stats.json"
+    },
+    "cost_per_unique_action_type": {
+      "$ref": "ads_action_stats.json"
+    },
+    "cost_per_unique_click": {
+      "type": ["null", "number"]
+    },
+    "cost_per_unique_inline_link_click": {
+      "type": ["null", "number"]
+    },
+    "cost_per_unique_outbound_click": {
+      "$ref": "ads_action_stats.json"
+    },
+    "cpc": {
+      "type": ["null", "number"]
+    },
+    "cpm": {
+      "type": ["null", "number"]
+    },
+    "cpp": {
+      "type": ["null", "number"]
+    },
+    "created_time": {
+      "format": "date",
+      "type": ["null", "string"]
+    },
+    "ctr": {
+      "type": ["null", "number"]
+    },
+    "date_start": {
+      "format": "date",
+      "type": ["null", "string"]
+    },
+    "date_stop": {
+      "format": "date",
+      "type": ["null", "string"]
+    },
+    "engagement_rate_ranking": {
+      "type": ["null", "string"]
+    },
+    "estimated_ad_recall_rate": {
+      "type": ["null", "number"]
+    },
+    "estimated_ad_recall_rate_lower_bound": {
+      "type": ["null", "number"]
+    },
+    "estimated_ad_recall_rate_upper_bound": {
+      "type": ["null", "number"]
+    },
+    "estimated_ad_recallers": {
+      "type": ["null", "number"]
+    },
+    "estimated_ad_recallers_lower_bound": {
+      "type": ["null", "number"]
+    },
+    "estimated_ad_recallers_upper_bound": {
+      "type": ["null", "number"]
+    },
+    "frequency": {
+      "type": ["null", "number"]
+    },
+    "full_view_impressions": {
+      "type": ["null", "number"]
+    },
+    "full_view_reach": {
+      "type": ["null", "number"]
+    },
+    "gender_targeting": {
+      "type": ["null", "string"]
+    },
+    "impressions": {
+      "type": ["null", "integer"]
+    },
+    "inline_link_click_ctr": {
+      "type": ["null", "number"]
+    },
+    "inline_link_clicks": {
+      "type": ["null", "integer"]
+    },
+    "inline_post_engagement": {
+      "type": ["null", "integer"]
+    },
+    "instant_experience_clicks_to_open": {
+      "type": ["null", "number"]
+    },
+    "instant_experience_clicks_to_start": {
+      "type": ["null", "number"]
+    },
+    "instant_experience_outbound_clicks": {
+      "$ref": "ads_action_stats.json"
+    },
+    "labels": {
+      "type": ["null", "string"]
+    },
+    "location": {
+      "type": ["null", "string"]
+    },
+    "mobile_app_purchase_roas": {
+      "$ref": "ads_action_stats.json"
+    },
+    "objective": {
+      "type": ["null", "string"]
+    },
+    "optimization_goal": {
+      "type": ["null", "string"]
+    },
+    "outbound_clicks": {
+      "$ref": "ads_action_stats.json"
+    },
+    "outbound_clicks_ctr": {
+      "$ref": "ads_action_stats.json"
+    },
+    "purchase_roas": {
+      "$ref": "ads_action_stats.json"
+    },
+    "qualifying_question_qualify_answer_rate": {
+      "type": ["null", "number"]
+    },
+    "quality_ranking": {
+      "type": ["null", "string"]
+    },
+    "reach": {
+      "type": ["null", "integer"]
+    },
+    "social_spend": {
+      "type": ["null", "number"]
+    },
+    "spend": {
+      "type": ["null", "number"]
+    },
+    "unique_actions": {
+      "$ref": "ads_action_stats.json"
+    },
+    "unique_clicks": {
+      "type": ["null", "integer"]
+    },
+    "unique_ctr": {
+      "type": ["null", "number"]
+    },
+    "unique_inline_link_click_ctr": {
+      "type": ["null", "number"]
+    },
+    "unique_inline_link_clicks": {
+      "type": ["null", "integer"]
+    },
+    "unique_link_clicks_ctr": {
+      "type": ["null", "number"]
+    },
+    "unique_outbound_clicks": {
+      "$ref": "ads_action_stats.json"
+    },
+    "unique_outbound_clicks_ctr": {
+      "$ref": "ads_action_stats.json"
+    },
+    "updated_time": {
+      "format": "date",
+      "type": ["null", "string"]
+    },
+    "video_15_sec_watched_actions": {
+      "$ref": "ads_action_stats.json"
+    },
+    "video_30_sec_watched_actions": {
+      "$ref": "ads_action_stats.json"
+    },
+    "video_avg_time_watched_actions": {
+      "$ref": "ads_action_stats.json"
+    },
+    "video_continuous_2_sec_watched_actions": {
+      "$ref": "ads_action_stats.json"
+    },
+    "video_p100_watched_actions": {
+      "$ref": "ads_action_stats.json"
+    },
+    "video_p25_watched_actions": {
+      "$ref": "ads_action_stats.json"
+    },
+    "video_p50_watched_actions": {
+      "$ref": "ads_action_stats.json"
+    },
+    "video_p75_watched_actions": {
+      "$ref": "ads_action_stats.json"
+    },
+    "video_p95_watched_actions": {
+      "$ref": "ads_action_stats.json"
+    },
+    "video_play_actions": {
+      "$ref": "ads_action_stats.json"
+    },
+    "video_play_curve_actions": {
+      "$ref": "ads_histogram_stats.json"
+    },
+    "video_play_retention_0_to_15s_actions": {
+      "$ref": "ads_histogram_stats.json"
+    },
+    "video_play_retention_20_to_60s_actions": {
+      "$ref": "ads_histogram_stats.json"
+    },
+    "video_play_retention_graph_actions": {
+      "$ref": "ads_histogram_stats.json"
+    },
+    "video_time_watched_actions": {
+      "$ref": "ads_action_stats.json"
+    },
+    "website_ctr": {
+      "$ref": "ads_action_stats.json"
+    },
+    "website_purchase_roas": {
+      "$ref": "ads_action_stats.json"
+    },
+    "wish_bid": {
+      "type": ["null", "number"]
+    }
+  },
+  "type": ["null", "object"]
+}

From 03874e83268e088f7a400cc19af694f589f506b3 Mon Sep 17 00:00:00 2001
From: Vinay Teki <vinayteki95@gmail.com>
Date: Wed, 14 Aug 2024 14:10:42 +0530
Subject: [PATCH 2/2] chore: removing deprecated files

---
 .../ads_insights_deprecated_after_v18.0.json  | 342 ------------------
 1 file changed, 342 deletions(-)
 delete mode 100644 airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ads_insights_deprecated_after_v18.0.json

diff --git a/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ads_insights_deprecated_after_v18.0.json b/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ads_insights_deprecated_after_v18.0.json
deleted file mode 100644
index 1428e2963307..000000000000
--- a/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ads_insights_deprecated_after_v18.0.json
+++ /dev/null
@@ -1,342 +0,0 @@
-{
-  "properties": {
-    "account_currency": {
-      "type": ["null", "string"]
-    },
-    "account_id": {
-      "type": ["null", "string"]
-    },
-    "account_name": {
-      "type": ["null", "string"]
-    },
-    "action_values": {
-      "$ref": "ads_action_stats.json"
-    },
-    "actions": {
-      "$ref": "ads_action_stats.json"
-    },
-    "ad_click_actions": {
-      "$ref": "ads_action_stats.json"
-    },
-    "ad_id": {
-      "type": ["null", "string"]
-    },
-    "ad_impression_actions": {
-      "$ref": "ads_action_stats.json"
-    },
-    "ad_name": {
-      "type": ["null", "string"]
-    },
-    "adset_id": {
-      "type": ["null", "string"]
-    },
-    "adset_name": {
-      "type": ["null", "string"]
-    },
-    "age_targeting": {
-      "type": ["null", "string"]
-    },
-    "attribution_setting": {
-      "type": ["null", "string"]
-    },
-    "auction_bid": {
-      "type": ["null", "number"]
-    },
-    "auction_competitiveness": {
-      "type": ["null", "number"]
-    },
-    "auction_max_competitor_bid": {
-      "type": ["null", "number"]
-    },
-    "buying_type": {
-      "type": ["null", "string"]
-    },
-    "campaign_id": {
-      "type": ["null", "string"]
-    },
-    "campaign_name": {
-      "type": ["null", "string"]
-    },
-    "canvas_avg_view_percent": {
-      "type": ["null", "number"]
-    },
-    "canvas_avg_view_time": {
-      "type": ["null", "number"]
-    },
-    "catalog_segment_actions": {
-      "$ref": "ads_action_stats.json"
-    },
-    "catalog_segment_value": {
-      "$ref": "ads_action_stats.json"
-    },
-    "catalog_segment_value_mobile_purchase_roas": {
-      "$ref": "ads_action_stats.json"
-    },
-    "catalog_segment_value_omni_purchase_roas": {
-      "$ref": "ads_action_stats.json"
-    },
-    "catalog_segment_value_website_purchase_roas": {
-      "$ref": "ads_action_stats.json"
-    },
-    "clicks": {
-      "type": ["null", "integer"]
-    },
-    "conversion_rate_ranking": {
-      "type": ["null", "string"]
-    },
-    "conversion_values": {
-      "$ref": "ads_action_stats.json"
-    },
-    "conversions": {
-      "$ref": "ads_action_stats.json"
-    },
-    "converted_product_quantity": {
-      "$ref": "ads_action_stats.json"
-    },
-    "converted_product_value": {
-      "$ref": "ads_action_stats.json"
-    },
-    "cost_per_15_sec_video_view": {
-      "$ref": "ads_action_stats.json"
-    },
-    "cost_per_2_sec_continuous_video_view": {
-      "$ref": "ads_action_stats.json"
-    },
-    "cost_per_action_type": {
-      "$ref": "ads_action_stats.json"
-    },
-    "cost_per_ad_click": {
-      "$ref": "ads_action_stats.json"
-    },
-    "cost_per_conversion": {
-      "$ref": "ads_action_stats.json"
-    },
-    "cost_per_estimated_ad_recallers": {
-      "type": ["null", "number"]
-    },
-    "cost_per_inline_link_click": {
-      "type": ["null", "number"]
-    },
-    "cost_per_inline_post_engagement": {
-      "type": ["null", "number"]
-    },
-    "cost_per_outbound_click": {
-      "$ref": "ads_action_stats.json"
-    },
-    "cost_per_thruplay": {
-      "$ref": "ads_action_stats.json"
-    },
-    "cost_per_unique_action_type": {
-      "$ref": "ads_action_stats.json"
-    },
-    "cost_per_unique_click": {
-      "type": ["null", "number"]
-    },
-    "cost_per_unique_inline_link_click": {
-      "type": ["null", "number"]
-    },
-    "cost_per_unique_outbound_click": {
-      "$ref": "ads_action_stats.json"
-    },
-    "cpc": {
-      "type": ["null", "number"]
-    },
-    "cpm": {
-      "type": ["null", "number"]
-    },
-    "cpp": {
-      "type": ["null", "number"]
-    },
-    "created_time": {
-      "format": "date",
-      "type": ["null", "string"]
-    },
-    "ctr": {
-      "type": ["null", "number"]
-    },
-    "date_start": {
-      "format": "date",
-      "type": ["null", "string"]
-    },
-    "date_stop": {
-      "format": "date",
-      "type": ["null", "string"]
-    },
-    "engagement_rate_ranking": {
-      "type": ["null", "string"]
-    },
-    "estimated_ad_recall_rate": {
-      "type": ["null", "number"]
-    },
-    "estimated_ad_recall_rate_lower_bound": {
-      "type": ["null", "number"]
-    },
-    "estimated_ad_recall_rate_upper_bound": {
-      "type": ["null", "number"]
-    },
-    "estimated_ad_recallers": {
-      "type": ["null", "number"]
-    },
-    "estimated_ad_recallers_lower_bound": {
-      "type": ["null", "number"]
-    },
-    "estimated_ad_recallers_upper_bound": {
-      "type": ["null", "number"]
-    },
-    "frequency": {
-      "type": ["null", "number"]
-    },
-    "full_view_impressions": {
-      "type": ["null", "number"]
-    },
-    "full_view_reach": {
-      "type": ["null", "number"]
-    },
-    "gender_targeting": {
-      "type": ["null", "string"]
-    },
-    "impressions": {
-      "type": ["null", "integer"]
-    },
-    "inline_link_click_ctr": {
-      "type": ["null", "number"]
-    },
-    "inline_link_clicks": {
-      "type": ["null", "integer"]
-    },
-    "inline_post_engagement": {
-      "type": ["null", "integer"]
-    },
-    "instant_experience_clicks_to_open": {
-      "type": ["null", "number"]
-    },
-    "instant_experience_clicks_to_start": {
-      "type": ["null", "number"]
-    },
-    "instant_experience_outbound_clicks": {
-      "$ref": "ads_action_stats.json"
-    },
-    "labels": {
-      "type": ["null", "string"]
-    },
-    "location": {
-      "type": ["null", "string"]
-    },
-    "mobile_app_purchase_roas": {
-      "$ref": "ads_action_stats.json"
-    },
-    "objective": {
-      "type": ["null", "string"]
-    },
-    "optimization_goal": {
-      "type": ["null", "string"]
-    },
-    "outbound_clicks": {
-      "$ref": "ads_action_stats.json"
-    },
-    "outbound_clicks_ctr": {
-      "$ref": "ads_action_stats.json"
-    },
-    "purchase_roas": {
-      "$ref": "ads_action_stats.json"
-    },
-    "qualifying_question_qualify_answer_rate": {
-      "type": ["null", "number"]
-    },
-    "quality_ranking": {
-      "type": ["null", "string"]
-    },
-    "reach": {
-      "type": ["null", "integer"]
-    },
-    "social_spend": {
-      "type": ["null", "number"]
-    },
-    "spend": {
-      "type": ["null", "number"]
-    },
-    "unique_actions": {
-      "$ref": "ads_action_stats.json"
-    },
-    "unique_clicks": {
-      "type": ["null", "integer"]
-    },
-    "unique_ctr": {
-      "type": ["null", "number"]
-    },
-    "unique_inline_link_click_ctr": {
-      "type": ["null", "number"]
-    },
-    "unique_inline_link_clicks": {
-      "type": ["null", "integer"]
-    },
-    "unique_link_clicks_ctr": {
-      "type": ["null", "number"]
-    },
-    "unique_outbound_clicks": {
-      "$ref": "ads_action_stats.json"
-    },
-    "unique_outbound_clicks_ctr": {
-      "$ref": "ads_action_stats.json"
-    },
-    "updated_time": {
-      "format": "date",
-      "type": ["null", "string"]
-    },
-    "video_15_sec_watched_actions": {
-      "$ref": "ads_action_stats.json"
-    },
-    "video_30_sec_watched_actions": {
-      "$ref": "ads_action_stats.json"
-    },
-    "video_avg_time_watched_actions": {
-      "$ref": "ads_action_stats.json"
-    },
-    "video_continuous_2_sec_watched_actions": {
-      "$ref": "ads_action_stats.json"
-    },
-    "video_p100_watched_actions": {
-      "$ref": "ads_action_stats.json"
-    },
-    "video_p25_watched_actions": {
-      "$ref": "ads_action_stats.json"
-    },
-    "video_p50_watched_actions": {
-      "$ref": "ads_action_stats.json"
-    },
-    "video_p75_watched_actions": {
-      "$ref": "ads_action_stats.json"
-    },
-    "video_p95_watched_actions": {
-      "$ref": "ads_action_stats.json"
-    },
-    "video_play_actions": {
-      "$ref": "ads_action_stats.json"
-    },
-    "video_play_curve_actions": {
-      "$ref": "ads_histogram_stats.json"
-    },
-    "video_play_retention_0_to_15s_actions": {
-      "$ref": "ads_histogram_stats.json"
-    },
-    "video_play_retention_20_to_60s_actions": {
-      "$ref": "ads_histogram_stats.json"
-    },
-    "video_play_retention_graph_actions": {
-      "$ref": "ads_histogram_stats.json"
-    },
-    "video_time_watched_actions": {
-      "$ref": "ads_action_stats.json"
-    },
-    "website_ctr": {
-      "$ref": "ads_action_stats.json"
-    },
-    "website_purchase_roas": {
-      "$ref": "ads_action_stats.json"
-    },
-    "wish_bid": {
-      "type": ["null", "number"]
-    }
-  },
-  "type": ["null", "object"]
-}