Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds test connector(ETL-295) #182

Merged
merged 4 commits into from
Mar 4, 2024
Merged

feat: adds test connector(ETL-295) #182

merged 4 commits into from
Mar 4, 2024

Conversation

a-rampalli
Copy link

What

Fixed mock connector and moved it to main branch for easy access.
Lot of functionality can be added to this connector like ability to sync long running jobs, stuck syncs, incremental resources etc but restricting current scope to basic working for now. Can work on a doc for all the tests we want to capture for extract and extend this as required.

Testing

Screenshot 2024-03-04 at 11 47 57 AM

Copy link

github-actions bot commented Mar 4, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@a-rampalli
Copy link
Author

ETL-295

@debanjan97
Copy link
Member

add an entry for test-connector to image building GHA

@a-rampalli a-rampalli changed the title feat: adds test connector feat: adds test connector(ETL-295) Mar 4, 2024
@a-rampalli
Copy link
Author

add an entry for test-connector to image building GHA

Good point. Adding

@a-rampalli a-rampalli merged commit 8f2c606 into main Mar 4, 2024
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants