Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JRuby support #13

Open
headius opened this issue Jan 26, 2022 · 3 comments
Open

JRuby support #13

headius opened this issue Jan 26, 2022 · 3 comments

Comments

@headius
Copy link

headius commented Jan 26, 2022

JRuby has a few minor modifications to tmpdir that we should evaluate to merge or remove. Most of these are pretty simple changes.

https://gist.github.com/headius/f972fdb91565828c76e78dcf4ae7f5be

I will do the work to get these changes incorporated into the gem.
@headius headius mentioned this issue Jan 27, 2022
Closed
@hsbt
Copy link
Member

hsbt commented Jan 27, 2022

I'm okay to merge JRuby's tmpdir changes if you want to keep it.

headius added a commit to headius/jruby that referenced this issue Jan 27, 2022
@headius
Update tmpdir.rb from 3.1
377030a 
The changes here are trivial, and tmpdir will move to a gem soon
once we have incorporated our minor changes. We will no longer
copy this from CRuby proper.

ruby/tmpdir#13
@headius headius mentioned this issue Nov 16, 2022
Open
40 tasks
@headius
Copy link
Author

headius commented Mar 1, 2023

So there are really only two changes:

  • Switch the etc.so require to etc
  • Deal with incompatibility in the change @nobu made in 2012: 82068d2

This second item will require fixes in JRuby, or reverting that line just for JRuby temporarily.

@headius
Copy link
Author

headius commented Mar 1, 2023

See also jruby/jruby#3698 which describes the problem with using join instead of expand_path on JRuby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@headius @hsbt