-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] I18n.exists?(nil) returns true #694
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What I tried to do
Using
I18n.exists?(key)
when the key is nilWhat I expected to happen
Expect
I18n.exists?(nil)
to throwI18n::ArgumentError
or return falseWhat actually happened
It returns true
Versions of i18n, rails, and anything else you think is necessary
The issue seems to come from this line.
Is there a specific reason why the line only checks if key is empty when it's string, instead of doing
raise I18n::ArgumentError if !key.is_a?(String) || key.empty?
The text was updated successfully, but these errors were encountered: