Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there tests? #10

Open
elicwhite opened this issue Jul 23, 2016 · 2 comments
Open

Are there tests? #10

elicwhite opened this issue Jul 23, 2016 · 2 comments

Comments

@elicwhite
Copy link

In the readme you state: "Every method has been tested" but I don't see any tests in the repo.

If we had automated tests for something like this, using something like travis, it would be super handy to know when niantic's server responses change and make sure that contributions don't break things.

@dmadisetti
Copy link
Collaborator

It's difficult to test against the Niantic servers when many of the calls are context dependent. Eg. I can't catch a pokemon unless I have a pokeball. Aside from that, I have thought about this and using think travis with fake PTC and google accounts could go a long way

@rubenvereecken
Copy link
Owner

I've seen someone else writing a Niantic mock server. If we could have that it'd be great for tests though not for checking when the version changes. However, the protobuf library we use is planning on getting protobuf tests up so we should be able to rely on those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants