Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something confused about addMapPointObservation #25

Open
dshwtc opened this issue Jul 12, 2018 · 0 comments
Open

Something confused about addMapPointObservation #25

dshwtc opened this issue Jul 12, 2018 · 0 comments

Comments

@dshwtc
Copy link

dshwtc commented Jul 12, 2018

Hi, I‘ve read your code recently, and I found something confused.
It's on line 608 and line 618 in mapHandler.cpp which shows below,

Vector3d dir_kf = Pf_kf.normalized();
dir_kf = curr_kf->T_kf_w.block(0,0,3,3) * dir_kf + curr_kf->T_kf_w.col(3).head(3);

I think this two sentences transform a 3D direction vector(3D point been normalized) from the keyframe frame to the world frame, and this is different from the other places when using the function "addMapPointObservation" which transfrom the 3D point first then normalized.
Is this something wrong?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant