This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Proposal of version 1.0.0 #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow user to set encoding of files, transcoding to UTF-8 Ruby 1.9 is much more strict about encodings; instead of just reading bytes into the string and hoping you know how to interpret it, it actually keeps track of what encoding it expects the file and the string to be and transcodes between them. This means that we can no longer just read in the ISO-8859-1 as binary, and kind of hope that everything later on ignores it or knows how to cope. Instead, we need to explicitly choose to read the file as ISO-8859-1, and explicitly choose the encoding that we want the string to be in. We use UTF-8, because that's what Pygments and at least some of the Markdown libraries are expecting. Fixes: rtomayko#73 (fix rtomayko#73)
|
Thumbs up! Excellent work! |
|
@krainboltgreene Thanks, Kurtis! |
|
Is there any reason why Rocco has been on 0.8.1 for so long while there are already a lot of pull requests (and the current version doesn't even work with Rails 3.2)? I know master works with 3.2 but I was just wondering... |
|
@JeanMertz I think Ryan (@rtomayko) is busy because of other projects. |
|
@yumitsu I mentioned it because - like I said - the latest stable gem seems to choke when using it with Rails 3.2 (or does it choke in Ruby 1.9.x?). Not sure exactly what happened, but I know i've been using the master version for some time now, because of this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
blueclothyumitsu@62ad28e8d33066568abb0ed4658c01ffbd847edf1.0.0yumitsu@ca9ce7e45860a186ee923b515f4f3b25b3b36e53