From a3b0f4b6dd8b4d24761685a0a6ab8fc11b151df1 Mon Sep 17 00:00:00 2001 From: Sabbir Ahmed Date: Fri, 28 May 2021 17:13:17 +0600 Subject: [PATCH 1/4] Fix php8 compatibility errors --- admin/rt-retranscode-admin.php | 7 +++---- inc/helpers/custom-functions.php | 18 +----------------- 2 files changed, 4 insertions(+), 21 deletions(-) diff --git a/admin/rt-retranscode-admin.php b/admin/rt-retranscode-admin.php index 14709ba..461b844 100644 --- a/admin/rt-retranscode-admin.php +++ b/admin/rt-retranscode-admin.php @@ -242,10 +242,9 @@ public function add_bulk_actions_via_javascript() { * @return void */ public function bulk_action_handler() { - - $action = transcoder_filter_input( INPUT_REQUEST, 'action', FILTER_SANITIZE_STRING ); - $action2 = transcoder_filter_input( INPUT_REQUEST, 'action2', FILTER_SANITIZE_STRING ); - $media = transcoder_filter_input( INPUT_REQUEST, 'media', FILTER_SANITIZE_NUMBER_INT, FILTER_REQUIRE_ARRAY ); + $action = transcoder_filter_input( INPUT_GET, 'action', FILTER_SANITIZE_STRING ); + $action2 = transcoder_filter_input( INPUT_GET, 'action2', FILTER_SANITIZE_STRING ); + $media = transcoder_filter_input( INPUT_GET, 'media', FILTER_SANITIZE_NUMBER_INT, FILTER_REQUIRE_ARRAY ); if ( empty( $action ) || empty( $media ) || ! is_array( $media ) || ( 'bulk_retranscode_media' !== $action && 'bulk_retranscode_media' !== $action2 ) diff --git a/inc/helpers/custom-functions.php b/inc/helpers/custom-functions.php index d63f2bd..03d4936 100644 --- a/inc/helpers/custom-functions.php +++ b/inc/helpers/custom-functions.php @@ -8,13 +8,12 @@ /** * This method is an improved version of PHP's filter_input() and * works well on PHP CLI as well which PHP default method does not. - * Also Provide support INPUT_REQUEST. * * Reference: * - https://bugs.php.net/bug.php?id=49184 * - https://bugs.php.net/bug.php?id=54672 * - * @param int $type One of INPUT_GET, INPUT_POST, INPUT_REQUEST, INPUT_COOKIE, INPUT_SERVER, or INPUT_ENV. + * @param int $type One of INPUT_GET, INPUT_POST, INPUT_COOKIE, INPUT_SERVER, or INPUT_ENV. * @param string $variable_name Name of a variable to get. * @param int $filter The ID of the filter to apply. * @param mixed $options filter to apply. @@ -24,21 +23,6 @@ */ function transcoder_filter_input( $type, $variable_name, $filter = FILTER_DEFAULT, $options = null ) { - /** - * Provide support of INPUT_REQUEST - * - * Reference: https://bugs.php.net/bug.php?id=54672 - */ - if ( INPUT_REQUEST === $type ) { - if ( isset( $_POST[ $variable_name ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing - $type = INPUT_POST; - } elseif ( isset( $_GET[ $variable_name ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended - $type = INPUT_GET; - } else { - return null; - } - } - if ( php_sapi_name() !== 'cli' ) { /** From 18b271a2cda79c733b77215aa741cfac0647a722 Mon Sep 17 00:00:00 2001 From: sid177 Date: Wed, 9 Jun 2021 11:24:53 +0000 Subject: [PATCH 2/4] Fix too few arguments error --- admin/rt-transcoder-functions.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/admin/rt-transcoder-functions.php b/admin/rt-transcoder-functions.php index ce6f39b..a14261b 100755 --- a/admin/rt-transcoder-functions.php +++ b/admin/rt-transcoder-functions.php @@ -385,12 +385,12 @@ function rtt_generate_video_shortcode( $html, $send_id, $attachment ) { * * @since 1.0.1 * - * @param string $content HTML contents of the activity. - * @param object $activity Activity object. + * @param string $content HTML contents of the activity. + * @param object|null $activity Activity object. * * @return string */ -function rtt_bp_get_activity_content( $content, $activity ) { +function rtt_bp_get_activity_content( $content, $activity = null ) { if ( empty( $activity ) || empty( $content ) ) { return $content; From 472c797ee7685291ec95b85138fc828611375855 Mon Sep 17 00:00:00 2001 From: Kapil Paul Date: Mon, 26 Jul 2021 12:48:51 +0600 Subject: [PATCH 3/4] Version update v1.3.4 --- README.md | 7 ++++ languages/transcoder.pot | 70 ++++++++++++++++++++-------------------- readme.txt | 16 +++++++-- rt-transcoder.php | 4 +-- 4 files changed, 57 insertions(+), 40 deletions(-) diff --git a/README.md b/README.md index 6653820..04e7732 100644 --- a/README.md +++ b/README.md @@ -65,6 +65,13 @@ Read [Documentation](https://rtmedia.io/docs/transcoder/?utm_source=readme&utm_m 1. Transcoder Settings ## Changelog ## +#### 1.3.4 [July 26, 2021] #### + +* FIXED + + * Transcoder plugin preventing read more from expanding + * Compatibility with WordPress 5.8 and PHP 8.0 + #### 1.3.3 [April 13, 2021] #### * FIXED diff --git a/languages/transcoder.pot b/languages/transcoder.pot index a0a1af5..44f248d 100644 --- a/languages/transcoder.pot +++ b/languages/transcoder.pot @@ -4,7 +4,7 @@ msgid "" msgstr "" "Project-Id-Version: \n" "Report-Msgid-Bugs-To: http://community.rtcamp.com/\n" -"POT-Creation-Date: 2021-04-13 11:35:10+00:00\n" +"POT-Creation-Date: 2021-07-26 06:48:11+00:00\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=utf-8\n" "Content-Transfer-Encoding: 8bit\n" @@ -207,7 +207,7 @@ msgstr "" #: admin/rt-retranscode-admin.php:119 admin/rt-retranscode-admin.php:120 #: admin/rt-retranscode-admin.php:192 admin/rt-retranscode-admin.php:213 -#: admin/rt-retranscode-admin.php:233 admin/rt-retranscode-admin.php:285 +#: admin/rt-retranscode-admin.php:233 admin/rt-retranscode-admin.php:284 msgid "Retranscode Media" msgstr "" @@ -215,40 +215,40 @@ msgstr "" msgid "Retranscode this single media" msgstr "" -#: admin/rt-retranscode-admin.php:293 +#: admin/rt-retranscode-admin.php:292 msgid "Cheatin’ uh?" msgstr "" -#: admin/rt-retranscode-admin.php:327 +#: admin/rt-retranscode-admin.php:326 #. translators: Link to the media page. msgid "Unable to find any media. Are you sure some exist?" msgstr "" -#: admin/rt-retranscode-admin.php:353 +#: admin/rt-retranscode-admin.php:352 msgid "There are no media available to send for transcoding." msgstr "" -#: admin/rt-retranscode-admin.php:363 +#: admin/rt-retranscode-admin.php:362 msgid "You do not have sufficient bandwidth remaining to perform the transcoding." msgstr "" -#: admin/rt-retranscode-admin.php:364 +#: admin/rt-retranscode-admin.php:363 msgid "Your remaining bandwidth is : " msgstr "" -#: admin/rt-retranscode-admin.php:365 +#: admin/rt-retranscode-admin.php:364 msgid "Required bandwidth is: " msgstr "" -#: admin/rt-retranscode-admin.php:369 +#: admin/rt-retranscode-admin.php:368 msgid "You can select the files manually and try again." msgstr "" -#: admin/rt-retranscode-admin.php:376 admin/rt-retranscode-admin.php:390 +#: admin/rt-retranscode-admin.php:375 admin/rt-retranscode-admin.php:389 msgid "Proceed with retranscoding" msgstr "" -#: admin/rt-retranscode-admin.php:404 +#: admin/rt-retranscode-admin.php:403 msgid "" "Your files are being re-transcoded. Do not navigate away from this page " "until the process is completed, as doing so will prematurely abort the " @@ -256,7 +256,7 @@ msgid "" "can view the progress below." msgstr "" -#: admin/rt-retranscode-admin.php:411 +#: admin/rt-retranscode-admin.php:410 #. translators: Count of media which were successfully transcoded with the time #. in seconds. msgid "" @@ -264,7 +264,7 @@ msgid "" "href=\"#\">click here." msgstr "" -#: admin/rt-retranscode-admin.php:414 +#: admin/rt-retranscode-admin.php:413 #. translators: Count of media which were successfully and media which were #. failed transcoded with the time in seconds and previout page link. msgid "" @@ -273,7 +273,7 @@ msgid "" "again, click here. %5$s" msgstr "" -#: admin/rt-retranscode-admin.php:416 +#: admin/rt-retranscode-admin.php:415 #. translators: Count of media which were successfully transcoded with the time #. in seconds and previout page link. msgid "" @@ -281,59 +281,59 @@ msgid "" "seconds and there were 0 failures. %3$s" msgstr "" -#: admin/rt-retranscode-admin.php:420 admin/rt-retranscode-admin.php:600 +#: admin/rt-retranscode-admin.php:419 admin/rt-retranscode-admin.php:599 msgid "You must enable Javascript in order to proceed!" msgstr "" -#: admin/rt-retranscode-admin.php:426 +#: admin/rt-retranscode-admin.php:425 msgid "Abort the Operation" msgstr "" -#: admin/rt-retranscode-admin.php:428 +#: admin/rt-retranscode-admin.php:427 msgid "Debugging Information" msgstr "" -#: admin/rt-retranscode-admin.php:433 +#: admin/rt-retranscode-admin.php:432 #. translators: Total count of the media. msgid "Total Media: %s" msgstr "" -#: admin/rt-retranscode-admin.php:438 +#: admin/rt-retranscode-admin.php:437 #. translators: Count of media which were successfully sent to the transcoder #. server. msgid "Media Sent for Retranscoding: %s" msgstr "" -#: admin/rt-retranscode-admin.php:443 +#: admin/rt-retranscode-admin.php:442 #. translators: Count of media which were failed while sending to the #. transcoder server. msgid "Failed While Sending: %s" msgstr "" -#: admin/rt-retranscode-admin.php:475 +#: admin/rt-retranscode-admin.php:474 msgid "Stopping..." msgstr "" -#: admin/rt-retranscode-admin.php:532 +#: admin/rt-retranscode-admin.php:531 #. translators: Media ID. msgid "" "The resize request was abnormally terminated (ID %s). This is likely due to " "the media exceeding available memory or some other type of fatal error." msgstr "" -#: admin/rt-retranscode-admin.php:585 +#: admin/rt-retranscode-admin.php:584 msgid "" "This tool will retranscode ALL audio/video media uploaded to your website. " "This can be handy if you need to transcode media files uploaded in the past." msgstr "" -#: admin/rt-retranscode-admin.php:587 +#: admin/rt-retranscode-admin.php:586 msgid "" "Sending your entire media library for retranscoding can consume a lot of " "your bandwidth allowance, so use this tool with care." msgstr "" -#: admin/rt-retranscode-admin.php:592 +#: admin/rt-retranscode-admin.php:591 #. translators: Placeholder is for admin media section link. msgid "" "You can retranscode specific media files (rather than ALL media) from the " @@ -341,50 +341,50 @@ msgid "" "a specific media (audio/video) file." msgstr "" -#: admin/rt-retranscode-admin.php:596 +#: admin/rt-retranscode-admin.php:595 msgid "To begin, just press the button below." msgstr "" -#: admin/rt-retranscode-admin.php:598 +#: admin/rt-retranscode-admin.php:597 msgid "Retranscode All Media" msgstr "" -#: admin/rt-retranscode-admin.php:635 +#: admin/rt-retranscode-admin.php:634 #. translators: Media id of the invalid media type. msgid "Sending Failed: %d is an invalid media ID/type." msgstr "" -#: admin/rt-retranscode-admin.php:640 +#: admin/rt-retranscode-admin.php:639 #. translators: Placeholder is for Media Name and ID of media. msgid "" ""%1$s" (ID %2$s) is MP3 file already. No need to send for " "transcoding" msgstr "" -#: admin/rt-retranscode-admin.php:644 +#: admin/rt-retranscode-admin.php:643 msgid "Your user account doesn't have permission to transcode" msgstr "" -#: admin/rt-retranscode-admin.php:649 +#: admin/rt-retranscode-admin.php:648 msgid "The media is already being transcoded" msgstr "" -#: admin/rt-retranscode-admin.php:696 +#: admin/rt-retranscode-admin.php:695 msgid "Unknown failure reason." msgstr "" -#: admin/rt-retranscode-admin.php:702 +#: admin/rt-retranscode-admin.php:701 #. translators: Media name, Media id and success message for successfull #. transcode. msgid ""%1$s" (ID %2$s) was successfully sent in %3$s seconds." msgstr "" -#: admin/rt-retranscode-admin.php:714 +#: admin/rt-retranscode-admin.php:713 #. translators: Media name, Media ID and message for failed transcode. msgid ""%1$s" (ID %2$s) failed to sent. The error message was: %3$s" msgstr "" -#: admin/rt-retranscode-admin.php:736 +#: admin/rt-retranscode-admin.php:735 msgid "Insufficient bandwidth!" msgstr "" diff --git a/readme.txt b/readme.txt index ee27ee7..4a01313 100644 --- a/readme.txt +++ b/readme.txt @@ -1,10 +1,10 @@ === Transcoder === -Contributors: rtcamp, mangeshp, chandrapatel, manishsongirkar36, bhargavbhandari90, kiranpotphode, thrijith, devikvekariya, sagarnasit, sudhiryadav, sid177, pooja1210, vaishu.agola27, ravatparmar, tremidkhar +Contributors: rtcamp, mangeshp, chandrapatel, manishsongirkar36, bhargavbhandari90, kiranpotphode, thrijith, devikvekariya, sagarnasit, sudhiryadav, sid177, pooja1210, vaishu.agola27, ravatparmar, tremidkhar, kapilpaul Tags: media, multimedia, audio, songs, music, video, ffmpeg, media-node, rtMedia, WordPress, kaltura, transcode, transcoder, encoding, encode Donate link: https://rtcamp.com/donate/ Requires at least: 4.1 -Tested up to: 5.7 -Stable tag: 1.3.3 +Tested up to: 5.8 +Stable tag: 1.3.4 License: GPLv2 or later License URI: http://www.gnu.org/licenses/gpl-2.0.html @@ -62,6 +62,13 @@ Read [Documentation](https://rtmedia.io/docs/transcoder/?utm_source=readme&utm_m 1. Transcoder Settings == Changelog == += 1.3.4 [July 26, 2021] = + +* FIXED + + * Transcoder plugin preventing read more from expanding + * Compatibility with WordPress 5.8 and PHP 8.0 + = 1.3.3 [April 13, 2021] = * FIXED @@ -203,5 +210,8 @@ Read [Documentation](https://rtmedia.io/docs/transcoder/?utm_source=readme&utm_m Initial release == Upgrade Notice == += 1.3.4 = +Transcoder 1.3.4, with added fix for plugin preventing read more from expanding in activity page and WordPress 5.8 and PHP 8.0 compatibility. + = 1.3.3 = Transcoder 1.3.3, with WordPress 5.7 compatibility and fix for license key not getting saved for WordPress installed in sub-directory. diff --git a/rt-transcoder.php b/rt-transcoder.php index 9269091..ae12f0e 100644 --- a/rt-transcoder.php +++ b/rt-transcoder.php @@ -3,7 +3,7 @@ * Plugin Name: Transcoder * Plugin URI: https://rtmedia.io/transcoder/?utm_source=dashboard&utm_medium=plugin&utm_campaign=transcoder * Description: Audio & video transcoding services for ANY WordPress website. Allows you to convert audio/video files of any format to a web-friendly format (mp3/mp4). - * Version: 1.3.3 + * Version: 1.3.4 * Text Domain: transcoder * Author: rtCamp * Author URI: https://rtcamp.com/?utm_source=dashboard&utm_medium=plugin&utm_campaign=transcoder @@ -39,7 +39,7 @@ /** * The version of the plugin */ - define( 'RT_TRANSCODER_VERSION', '1.3.3' ); + define( 'RT_TRANSCODER_VERSION', '1.3.4' ); } if ( ! defined( 'RT_TRANSCODER_NO_MAIL' ) && defined( 'VIP_GO_APP_ENVIRONMENT' ) ) { From 9ab80cf5c41710df4090996b21befc51f47097bd Mon Sep 17 00:00:00 2001 From: sid177 Date: Tue, 17 Aug 2021 13:24:38 +0530 Subject: [PATCH 4/4] Update release date --- README.md | 2 +- languages/transcoder.pot | 2 +- readme.txt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 04e7732..8d8968c 100644 --- a/README.md +++ b/README.md @@ -65,7 +65,7 @@ Read [Documentation](https://rtmedia.io/docs/transcoder/?utm_source=readme&utm_m 1. Transcoder Settings ## Changelog ## -#### 1.3.4 [July 26, 2021] #### +#### 1.3.4 [August 17, 2021] #### * FIXED diff --git a/languages/transcoder.pot b/languages/transcoder.pot index 44f248d..90942a3 100644 --- a/languages/transcoder.pot +++ b/languages/transcoder.pot @@ -4,7 +4,7 @@ msgid "" msgstr "" "Project-Id-Version: \n" "Report-Msgid-Bugs-To: http://community.rtcamp.com/\n" -"POT-Creation-Date: 2021-07-26 06:48:11+00:00\n" +"POT-Creation-Date: 2021-08-17 07:53:36+00:00\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=utf-8\n" "Content-Transfer-Encoding: 8bit\n" diff --git a/readme.txt b/readme.txt index 4a01313..649a5b1 100644 --- a/readme.txt +++ b/readme.txt @@ -62,7 +62,7 @@ Read [Documentation](https://rtmedia.io/docs/transcoder/?utm_source=readme&utm_m 1. Transcoder Settings == Changelog == -= 1.3.4 [July 26, 2021] = += 1.3.4 [August 17, 2021] = * FIXED