Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change API to use "const char" for strings that are actually constant #86

Open
rgerhards opened this issue Apr 18, 2018 · 1 comment
Open
Assignees

Comments

@rgerhards
Copy link
Member

rgerhards commented Apr 18, 2018

Unfortunately the API did expose them as char. This is bad from a "clean compile" perspective, but may also convey the idea that these strings are actually modifiable. That is not the case, because it's almost constant string, and so any try to modify them can result in a segfault (depending on platform).

We need to check, though, if fixing this is causing severe trouble. If so, we need to re-evaluate.

@rgerhards rgerhards added this to the v1.2.16 milestone Apr 18, 2018
@rgerhards rgerhards self-assigned this Apr 18, 2018
@rgerhards rgerhards modified the milestones: v1.2.16, v1.2.17 May 7, 2018
@rgerhards
Copy link
Member Author

moving this to 1.2.17 milestone as it requires API user changes, something we do not want to do shortly before rsyslog release; also want to make sure that all existing clients can enjoy the enhancements and fixes in 1.2.16 without change.

rgerhards added a commit to rgerhards/librelp that referenced this issue May 7, 2018
NOTE: this requires changes to ALL existing clients!

closes rsyslog#86
@rgerhards rgerhards removed this from the v1.2.17 milestone Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant