Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade DataTables to v1.13.11 #1141

Open
stla opened this issue Jun 7, 2024 · 2 comments · May be fixed by #1147
Open

Upgrade DataTables to v1.13.11 #1141

stla opened this issue Jun 7, 2024 · 2 comments · May be fixed by #1147

Comments

@stla
Copy link
Collaborator

stla commented Jun 7, 2024

Hello Yihui,

I wanted to do a PR to upgrade DataTables to v1.13.11 (the last 1.x version) but there are some problems.

The DataTables website provides a download builder for v1.13.11 but this download builder is not the same as before. You can select the files you want as before but then it only provides the links to these files, there's no longer a Download button:

datatablesDownload

Before, as I remember (not sure to correctly remember), there was a Download button and one got a zip containing some folders, e.g. one folder for each extension. I could manually put the extensions files in their respective folder, this is not a problem, but there is another problem. In addition to the extension files, this download builder only provides the links to dataTables.dataTables.min.css and jQuery.dataTables.min.js. However, before, there were more files in the zip, e.g. datatables.min.js and datatables.bootstrap5.min.js.

So I don't know how to proceed. Would you have an idea?

@yihui
Copy link
Member

yihui commented Jun 8, 2024

@stla Unfortunately, I'm insanely busy recently and don't have time to look into this. Previously, we have been using this script to upgrade DataTables: https://github.com/rstudio/DT/blob/main/tools/update_DT.R I'm not sure if it still works.

BTW, I have also transferred the maintenance of DT to Posit in April (c95609c). I think it will be very unlikely that I'll be able to review your PR of upgrading the library this year. Thanks a lot for your interest and contributions anyway!

@stla
Copy link
Collaborator Author

stla commented Jul 17, 2024

Hi Yihui,

I can see you're insanely busy because you didn't carefully read my message, which is unusual. Your script still works in principle but the problem is that the download builder on the datatables website is now a legacy version and it has changed, so your script no longer applies to this download builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants