-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The builder depends on internal use of handlebars
that will be removed in Storybook 8.4
#136
Comments
JReinhold
changed the title
RSBuild depends on internal use of
The builder depends on internal use of Oct 4, 2024
handlebars
that will be removed in Storybook 8.4handlebars
that will be removed in Storybook 8.4
Thanks @JReinhold for the kind remind. I'll do the same migration quickly. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For Storybook 8.4 we're doing a lot of internal cleanup and optimisation (see storybookjs/storybook#29038).
As part of my work to replace the
express
dev-server withpolka
, I wanted to try out if that worked with RSBuild, because the server is exposed to the builders via thestart()
function. However I never got that far, because RSBuild fails with the following error in the latest alpha releases of Storybook8.4.0
:This is because we've removed
handlebars
from the Storybookcore/common
exports, as it was unnecessary. It was never intended to be used as a public API, but it's fair that you perhaps just copied the logic from the Webpack builder.You should be able to to the same migration that @ndelangen we did for the Webpack builder in storybookjs/storybook#29208. High-level, that PR:
'{{someVariable}}'
for stuff that needs replacementreplaceAll()
calls to do the variable replacements.The text was updated successfully, but these errors were encountered: