Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Proto 3 Optionals #77

Open
ummels opened this issue Nov 22, 2021 · 1 comment
Open

Add support for Proto 3 Optionals #77

ummels opened this issue Nov 22, 2021 · 1 comment

Comments

@ummels
Copy link

ummels commented Nov 22, 2021

Protobuf 3.12 has added support for optional fields, and with version 3.15 this is no longer an experimental feature.

Since the compiler plugin for rsocket-rpc-java depends on an older version of protoc, the plugin currently fails when confronted with a service definition that contains optional fields.

Please upgrade protoc and protobuf dependencies to a newer version so that the plugin can handle service definitions with optional fields. Since optional fields do not change the semantics of the code generated by this plugin, this should be enough in order to support optionals.

@iamceph
Copy link

iamceph commented Jan 4, 2022

This is a needed enhancement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants