Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rsocket object supports obtaining local address and remote address #1011

Closed
atshow opened this issue May 26, 2021 · 2 comments · May be fixed by #1013
Closed

Rsocket object supports obtaining local address and remote address #1011

atshow opened this issue May 26, 2021 · 2 comments · May be fixed by #1013
Labels
superseded Issue is superseded by another

Comments

@atshow
Copy link

atshow commented May 26, 2021

I'm using spring boot rsocket to develop microservices. Now I have a requirement to get the local address and remote address of the connection. I find that I can't get the local address and remote address from the rsocket object. Can we learn io.netty.channel.channel to add localAddress and remoteAddress methods to the rsocket object
@atshow atshow changed the title Whether rsocket object supports obtaining local address and remote address Rsocket object supports obtaining local address and remote address May 26, 2021
@atshow
Copy link
Author

atshow commented May 26, 2021

I have an idea to add two interfaces to the rsocket object, as shown below

public interface RSocket extends Availability, Closeable {
......
  default SocketAddress localAddress() {
    return null;
  }

  default SocketAddress remoteAddress() {
    return null;
  }
......
}

@atshow
Copy link
Author

atshow commented May 31, 2021

I submitted a PR
#1013

@rstoyanchev rstoyanchev added the superseded Issue is superseded by another label Jun 1, 2021
@rstoyanchev rstoyanchev linked a pull request Jun 1, 2021 that will close this issue
The rsocket object supports IP acquisition #1013
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
superseded Issue is superseded by another
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

The rsocket object supports IP acquisition atshow/rsocket-java
2 participants
@rstoyanchev @atshow