Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateinfo issues #919

Closed
glum23 opened this issue Sep 26, 2023 · 4 comments · Fixed by #920
Closed

updateinfo issues #919

glum23 opened this issue Sep 26, 2023 · 4 comments · Fixed by #920
Assignees

Comments

@glum23
Copy link
Contributor

glum23 commented Sep 26, 2023

According to #155, work on updateinfo command has been finished. However:

@kontura
Copy link
Contributor

kontura commented Sep 27, 2023

Thank you for the report!
I have created a PR #920 which documents the changes.

Regarding the dnf5 updateinfo --help not showing any options. I think that is expected, the options are for subcommands: dnf5 updateinfo info --help.

@glum23
Copy link
Contributor Author

glum23 commented Sep 27, 2023

Thank you for the report! I have created a PR #920 which documents the changes.

Thanks!

Regarding the dnf5 updateinfo --help not showing any options. I think that is expected, the options are for subcommands: dnf5 updateinfo info --help.

I'd expect the output of dnf5 updateinfo --help similar to the related man page (especially because all subcommands' options are the same), sth like:

Usage:
  dnf5 advisory <COMMAND> [GLOBAL OPTIONS] [OPTIONS] [ARGUMENTS]
Command:                 
  list                          List advisories
  info                          Print details about advisories
  summary                       Print summary of advisories
Options:                         
 <list of options>
Arguments:                                     
  advisory-spec                                List of patterns matched against advisory names.

From my POV, seeking the relevant options in two steps is unnecessarily protracted. However, the current solution is consistent.

@kontura
Copy link
Contributor

kontura commented Sep 27, 2023

They are the same for updateinfo but it doesn't have to be like that in general.
For example dnf5 group list --help vs dnf5 group install --help.

But I see your point about the man page.
I agree it is something to consider (probably worth making a new issue for that).

@glum23
Copy link
Contributor Author

glum23 commented Sep 27, 2023

new issue: #921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants