-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"dnf --help" output is not mostly internationalized #1736
Comments
*.pot files, like dnf5/po/dnf5.pot, are not updated here. They are instead updated in https://github.com/rpm-software-management/dnf5-l10n repository every day. The translations are then copied back just before every DNF5 release. It's so not to clutter commit history of this repository with updates from translators. Another reason is to prevent Weblate service from running into merge conflicts. But I agree that it's confusing. Another question is why the texts you showed in the image are not localized. It's because the texts are not marked for a translation in the code. That needs to be fixed. |
Thanks for the clarification. It turns out that dnf5-i10n's dnf5.pot files are updated regularly, so I don't need to worry about them. I should have checked that first. |
I still need to understand why translated entries are not appearing as translated in dnf5. When I run
From what I understand, When I count the number of lines starting with
I also ran It seems that the outdated |
You are right. The translation template files are never updated in dnf5 repository and thus any msgmerge call removes newly added strings for translation. It's a bug in .github/actions/weblate-pull-translations/action.yml script. I opened issue #1744. |
Use `_(msgId)` in bgettext-lib.h to mark texts as eligible for translation. Partially resolves: rpm-software-management#1736
Use `_(msgId)` in bgettext-lib.h to mark texts as eligible for translation. Related: rpm-software-management#1736
Use _(msgId) in bgettext-lib.h to mark text as eligible for translation. This will allow translators to translate the short descriptions of the commands in dnf5 --help. Further changes will be required to make each command description translatable. Related: rpm-software-management#1736
Use _(msgId) in bgettext-lib.h to mark text as eligible for translation. This will allow translators to translate the short descriptions of the commands in dnf5 --help. Further changes will be required to make each command description translatable. Related: #1736
It seems that the POT file at https://github.com/rpm-software-management/dnf5/blob/5.2.6.2/dnf5/po/dnf5.pot was last updated on 2023-11-21, which is more than 10 months ago. When I run
$ ninja dnf5-pot
in the dnf5 source repository, a surprisingly large number of strings are updated. This implies that current translations are referring to outdated strings, meaning that even though translation contributors might think their work is 100% complete, many of the texts are actually not translated.Here’s the output of
$ git diff --stat dnf5/po
over generated POT file changes:I believe we need to update the POT files for dnf5, and it might be beneficial to update them automatically (e.g., every month) to avoid this situation.
The image below shows the result of
$ dnf --help
in Korean, where many strings are not translated. (dnf5-5.2.6.2-1.fc41.x86_64):The text was updated successfully, but these errors were encountered: