Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we add pkg_gpgcheck as the supported option and make gpgcheck an alias to that (for now)? #1649

Open
kontura opened this issue Aug 22, 2024 · 1 comment

Comments

@kontura
Copy link
Contributor

kontura commented Aug 22, 2024

Could we add pkg_gpgcheck as the supported option and make gpgcheck an alias to that (for now)? That would let us make a step toward #727...

Originally posted by @Conan-Kudo in #1648 (comment)

@jan-kolarik
Copy link
Member

IIUC, this doesn't change any existing behavior. If that's the case, I have no issue with it.

kontura added a commit to kontura/dnf5 that referenced this issue Oct 9, 2024
Changes to name to a more apt `pkg_gpgcheck` but `gpgcheck` is still
accepted. At this point I am not sure we will ever be able to drop it.

It also adds new getter API to both main and repo: `get_pkg_gpgcheck_option`
and depracates the old `get_gpgcheck_option`.

For: rpm-software-management#1649
kontura added a commit to kontura/dnf5 that referenced this issue Oct 9, 2024
Changes the name to a more apt `pkg_gpgcheck` but `gpgcheck` is still
accepted. At this point I am not sure we will ever be able to drop it.

It adds new getter API to both main and repo: `get_pkg_gpgcheck_option`
and depracates the old `get_gpgcheck_option`.
It also extends `libdnf5::cli::output::IRepoInfo` with `get_pkg_gpgcheck`
and the `dnf5daemon-server` should also accept `pkg_gpgcheck` attribute.

For: rpm-software-management#1649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants