Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copr plugin: _guess_chroot does not handle centos stream properly #524

Open
jakub-vavra-cz opened this issue Mar 1, 2024 · 1 comment · May be fixed by #525
Open

copr plugin: _guess_chroot does not handle centos stream properly #524

jakub-vavra-cz opened this issue Mar 1, 2024 · 1 comment · May be fixed by #525

Comments

@jakub-vavra-cz
Copy link

I am trying to enable repo on centos stream 9 "dnf -y copr enable --hub copr.fedorainfracloud.org @sssd/pr7193"
It is incorrectly defaulting to epel-9-x86_64 instead of centos-stream-9-x86_64:

2024-03-01T11:35:55 Repository 'epel-9-x86_64' does not exist in project '@sssd/pr7193'.
2024-03-01T11:35:55 Available repositories: 'fedora-38-x86_64', 'fedora-40-x86_64', 'centos-stream-9-x86_64', 'fedora-rawhide-x86_64', 'fedora-39-x86_64'

I do not want to put there repo explicitly as I want to reuse same code on centos, fedora and rhel.
@jakub-vavra-cz jakub-vavra-cz linked a pull request Mar 1, 2024 that will close this issue
Open
jakub-vavra-cz added a commit to jakub-vavra-cz/dnf-plugins-core that referenced this issue Mar 1, 2024
@jakub-vavra-cz
Detect CentOS and RHEL properly instead of defaulting to epel
64e29b8 
= changelog =
msg: Fix detection of CentOS Stream and Red Hat Enterprise Linux
type: bugfix
resolves: rpm-software-management#524
jakub-vavra-cz added a commit to jakub-vavra-cz/dnf-plugins-core that referenced this issue Mar 8, 2024
@jakub-vavra-cz
Detect CentOS properly instead of defaulting to epel
2aaeccb 
= changelog =
msg: Fix detection of CentOS Stream
type: bugfix
resolves: rpm-software-management#524
@carlwgeorge
Copy link
Contributor

carlwgeorge commented Apr 27, 2024 •
edited
Loading

Back in version 4.0.23 and earlier of the plugin, CentOS Stream would match EPEL chroots because epel-%s-x86_64 was the default if the system didn't identify as Fedora, Mageia, or openSUSE. In version 4.0.24, this was "fixed" to special case CentOS Stream to match centos-stream-{0}-{1} chroots. This caused lots of complaints from users and maintainers, for several reasons.

  • EPEL itself targets compatibility with CentOS Stream, so EPEL copr chroots not being picked surprises users.
  • Many copr projects enable EPEL chroots, but very few enable CentOS Stream chroots.
  • A copr project that enables CentOS Stream chroots will not have access to other EPEL packages which may be build requirements during its builds, leading to failed builds.

Due to these problems, that "fix" was reverted in version 4.3.0. Reverting the revert will be a mistake and bring back all of these same problems. This issue and the accompanying pull request (#525) should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Detect CentOS properly instead of defaulting to epel jakub-vavra-cz/dnf-plugins-core
2 participants
@carlwgeorge @jakub-vavra-cz