Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose to move react and react-dom to peerDependencies #104

Open
Kudo opened this issue Jul 12, 2017 · 3 comments
Open

Propose to move react and react-dom to peerDependencies #104

Kudo opened this issue Jul 12, 2017 · 3 comments

Comments

@Kudo
Copy link

Kudo commented Jul 12, 2017

Currently react and react-dom specified as dependencies in package.json.
If user use next React version, e.g. React v16, there will have some unexpected dependencies in node_modules.
Here to propose move them as peerDependencies.

@IanVS
Copy link

IanVS commented Oct 2, 2017

The dependencies will only be there for development builds though. If installing only production modules, as long as flow-coverage-report is listed as a devDepencency, it won't get installed.

@swac
Copy link

swac commented Oct 2, 2018

Any update here? It feels weird to have React 15 in our dependency graph, even if it's just a dev dependency.

@NameFILIP
Copy link

I noticed React 15 in the dependency graph as well today. Any ideas on how this can be solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants