-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strings are not escaped #7
Comments
The same issue exists for the username parameter in Changing the /Utilities/ActionProxy.cs ActionProxy.ProcessParameters accordingly should fix those issues and retain backward compatibility:
...sorry for just copying the code instead of creating a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, using
Method("Local Area Network")
will result in... method argument=Local Area Network
.Doing so will result in an error because how the parsing of the cmd works.
In your test code, you manually escaped your input strings via
"\""
, which seems a bit counter-intuitive.A little check if the string contains a space and is not escaped would go a long way.
Is there a particular reason why strings that contain spaces are not automatically escaped?
Also this command (WLAN/SetActionTests.cs => VerifyProfileParameterOutput) would not execute correctly (
interface sl
is not escaped) and from what I get all your test commands are supposed to work (with correct parameters and names).PS: Sorry for my poor English and double sorry If I misused the issues function somehow (I'm somewhat new to github).
The text was updated successfully, but these errors were encountered: