Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display diff using side by side presentation #2

Open
GoogleCodeExporter opened this issue Aug 22, 2015 · 8 comments
Open

Display diff using side by side presentation #2

GoogleCodeExporter opened this issue Aug 22, 2015 · 8 comments

Comments

@GoogleCodeExporter
Copy link

Similar to how Gerrit formats a file side by side, allow viewing a modified 
text file in a side by side view.

Gerrit's method of rendering this in a 4 column table with each line being a 
new row is horrid and should be replicated. Critique and GitHub get this more 
right by rendering 4 divs in a 1 row table, enabling the user to select a 
contiguous section of source code from either side.

Original issue reported on code.google.com by [email protected] on 11 Nov 2012 at 11:17

@GoogleCodeExporter
Copy link
Author

I don't really want to reinvent the wheel here. IMHO we should reuse the side 
by side diff logic from Gerrit, but of course that's currently impossible 
because Gerrit uses GWT, and does various other things wrong. So, first let's 
fix Gerrit.

Original comment by [email protected] on 11 Nov 2012 at 11:19

@GoogleCodeExporter
Copy link
Author

Gerrit is looking at moving to Codemirror for side-by-side diffs. We should do 
that too: not too much fancy JS, hopefully largely pasting it in, I haven't 
looked. Even if not, we should be able to reuse more code because it's just the 
server-side stuff (serving diff info), no more GWT.

Original comment by [email protected] on 19 Jun 2013 at 12:26

@GoogleCodeExporter
Copy link
Author

For reference, I requested this via email as something that I think is 
important for parity between ViewVC and gitiles if Chromium is moving from the 
former to the latter.

Original comment by [email protected] on 5 May 2014 at 4:26

@GoogleCodeExporter
Copy link
Author

Can/should it be optional? I personally prefer the single format.

Original comment by [email protected] on 6 May 2014 at 10:58

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 26 Aug 2014 at 12:06

@GoogleCodeExporter
Copy link
Author

Any update on the prospects for this?

Original comment by [email protected] on 26 Aug 2014 at 12:08

@GoogleCodeExporter
Copy link
Author

Issue chromium:384604 has been merged into this issue.

Original comment by [email protected] on 26 Aug 2014 at 12:16

@GoogleCodeExporter
Copy link
Author

Nope. :(

IIRC we tried using CodeMirror3 and it was too slow/awkward to use for Chromium 
project. So a new side by side view needs to be built from scratch in Gitiles, 
but that work hasn't been estimated or scheduled.

Original comment by [email protected] on 26 Aug 2014 at 12:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant