Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I have a better way to solve exercise 24 #216

Open
anthonyduong9 opened this issue Sep 29, 2024 · 1 comment · May be fixed by #220
Open

I have a better way to solve exercise 24 #216

anthonyduong9 opened this issue Sep 29, 2024 · 1 comment · May be fixed by #220

Comments

@anthonyduong9
Copy link

anthonyduong9 commented Sep 29, 2024 •
edited
Loading

I think

Z = np.matmul(np.ones((5, 3)), np.ones((3, 2)))

would be better than

numpy-100/100_Numpy_exercises_with_hints_with_solutions.md

Line 205 in 916e1ec

Z = np.dot(np.ones((5,3)), np.ones((3,2)))

because the docs say

"If both a and b are 2-D arrays, it is matrix multiplication, but using matmul or a @ b is preferred.".
@rougier
Copy link
Owner

rougier commented Oct 21, 2024

Thanks, you're right. Can you make a PR?

@anthonyduong9 anthonyduong9 linked a pull request Oct 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

solves exercise 24 anthonyduong9/numpy-100
2 participants
@rougier @anthonyduong9