Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong letter case in a constant name #274

Open
wzhqwq opened this issue Nov 4, 2023 · 2 comments
Open

Wrong letter case in a constant name #274

wzhqwq opened this issue Nov 4, 2023 · 2 comments

Comments

@wzhqwq
Copy link

wzhqwq commented Nov 4, 2023

An incorrect modification was made to a constant name in #235, causing a build failure.

The FONTCONFIG_LIBRARY is set in FindConfigFont.cmake while the Fontconfig_LIBRARY is used in demos/CMakeLists.txt. Therefore the library path of FontConfig is not included in the linking phase of target markup, resulting in the following error:

...
[ 94%] Linking C executable markup
Undefined symbols for architecture x86_64:
  "_FcConfigSubstitute", referenced from:
      _match_description in markup.c.o
  "_FcDefaultSubstitute", referenced from:
      _match_description in markup.c.o
  "_FcFontMatch", referenced from:
      _match_description in markup.c.o
  "_FcInit", referenced from:
      _match_description in markup.c.o
  "_FcNameParse", referenced from:
      _match_description in markup.c.o
  "_FcPatternDestroy", referenced from:
      _match_description in markup.c.o
  "_FcPatternGet", referenced from:
      _match_description in markup.c.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [demos/markup] Error 1
make[1]: *** [demos/CMakeFiles/markup.dir/all] Error 2
make: *** [all] Error 2
@rougier
Copy link
Owner

rougier commented Nov 16, 2023

Thanks for the report and the identification of the problem. Not sure why it was reported earlier and I don't remember why I merged the initial commit. Could you make a PR?

@wzhqwq
Copy link
Author

wzhqwq commented Nov 21, 2023

I tried it in a linux environment where the original version works fine but the modified version inexplicably fails.
I'm using Mac where things go oppositely.
It might be right not to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants