Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add rough mode #1457

Merged
merged 3 commits into from
May 23, 2024
Merged

feat: Add rough mode #1457

merged 3 commits into from
May 23, 2024

Conversation

sidharthv96
Copy link
Member

📑 Summary

Add rough mode as an option when rendering

Resolves rough-stuff/rough#203

📏 Design Decisions

Uses svg2roughjs library to render.
There are some "rough edges", but this works for majority of the diagrams.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

Copy link

netlify bot commented May 23, 2024

Deploy Preview for mermaidjs ready!

Name Link
🔨 Latest commit 4525e04
🔍 Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/664f3cbdd831610008c751ae
😎 Deploy Preview https://deploy-preview-1457--mermaidjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented May 23, 2024

Passing run #1445 ↗︎

0 29 6 0 Flakiness 0

Details:

Merge 20b4ecc into eb3b2d5...
Project: Mermaid Live Editor Commit: 95b4f6abdf ℹ️
Status: Passed Duration: 01:52 💡
Started: May 23, 2024 12:51 PM Ended: May 23, 2024 12:53 PM

Review all test suite changes for PR #1457 ↗︎

@sidharthv96 sidharthv96 added this pull request to the merge queue May 23, 2024
Merged via the queue into develop with commit ca03a85 May 23, 2024
9 of 10 checks passed
@sidharthv96 sidharthv96 deleted the sidv/rough branch May 23, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mermaid language to rough
1 participant