Updated \SlimMvcTools\Functions\CliHelpers\createController to return…

… \SlimMvcTools\Functions\CliHelpers\CliExitCodes::SUCCESS_EXIT when the controller class or index view to be created already exist.
rotexsoft · May 31, 2024 · bb3f808 · bb3f808
1 parent 38f637e
commit bb3f808
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/scripts/cli-script-helper-functions.php b/src/scripts/cli-script-helper-functions.php
@@ -439,15 +439,15 @@ function createController($argc, array $argv): CreateControllerReturnValue {
             if( file_exists($dest_controller_class_file) ) {
 
                 return new CreateControllerReturnValue(
-                    CliExitCodes::FAILURE_EXIT,
+                    CliExitCodes::SUCCESS_EXIT,
                     "Controller class `$studly_controller_name` already exists in `$dest_controller_class_file`. Goodbye!!"
                 );
             }
 
             if( file_exists($dest_view_file) ) {
 
                 return new CreateControllerReturnValue(
-                    CliExitCodes::FAILURE_EXIT,
+                    CliExitCodes::SUCCESS_EXIT,
                     "View file `$dest_view_file` already exists for Controller class `$studly_controller_name`. Goodbye!!"
                 );
             }

diff --git a/tests/CliScriptHelperFunctionsNamespacedTest.php b/tests/CliScriptHelperFunctionsNamespacedTest.php
@@ -258,7 +258,7 @@ public function testThatCreateControllerWorksAsExpectedWhenDestinationController
 
             $expected_message = "Controller class `ChildController` already exists in `{$dest_controller_class_file}`. Goodbye!!";
 
-            self::assertEquals(\SlimMvcTools\Functions\CliHelpers\CliExitCodes::FAILURE_EXIT, $return_val->getReturnCode());
+            self::assertEquals(\SlimMvcTools\Functions\CliHelpers\CliExitCodes::SUCCESS_EXIT, $return_val->getReturnCode());
             self::assertEquals($expected_message, $return_val->getReturnMessage());
         }
     }
@@ -291,7 +291,7 @@ public function testThatCreateControllerWorksAsExpectedWhenDestinationViewIndexD
 
             $expected_message = "View file `$dest_view_file` already exists for Controller class `ControllerWithNoControllerClass`. Goodbye!!";
 
-            self::assertEquals(\SlimMvcTools\Functions\CliHelpers\CliExitCodes::FAILURE_EXIT, $return_val->getReturnCode());
+            self::assertEquals(\SlimMvcTools\Functions\CliHelpers\CliExitCodes::SUCCESS_EXIT, $return_val->getReturnCode());
             self::assertEquals($expected_message, $return_val->getReturnMessage());
         }
     }