I think this brings up kind of a larger question. By IEEE-754 definition nan != nan, so if we have a message with a single float data field, both set to nan, should those messages be equal to each other?

I think this brings up kind of a larger question. By IEEE-754 definition nan != nan, so if we have a message with a single float data field, both set to nan, should those messages be equal to each other?

To me, they are the same message. You are checking equality of the messages and practically means the contents are the same.

For purposes of the equality, I use the operator just before a call to publish to check if the message is the same. If it's the same, publishing the same thing is a waste of CPU. That said, we can't assume that use case for everyone. As implemented, I vote for this behavior, but am open to other options.

I'm going to bring this up at our next team meeting, because I think you aren't wrong, but want to make sure that we think through the potential impacts.

I'm going to bring this up at our next team meeting, because I think you aren't wrong, but want to make sure that we think through the potential impacts.

Did you get any feedback? I'm still carrying all these patches internally, and would love to get them merged!