-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ros2component] Add tests for ros2component #390
base: rolling
Are you sure you want to change the base?
Conversation
Signed-off-by: Brian Ezequiel Marchi <[email protected]>
Signed-off-by: Brian Ezequiel Marchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BMarchi consider splitting this test into multiple launch tests, each can then setup the fixture appropriately e.g. preload components into the container before testing unload
or list
.
…ests Signed-off-by: Brian Ezequiel Marchi <[email protected]>
Something to notice is that these tests don't run with opensplice. It always hangs for almost all verb conditions which ends up failing every test. I suggest to create an issue for opensplice only. |
Signed-off-by: Brian Ezequiel Marchi <[email protected]>
Signed-off-by: Brian Ezequiel Marchi <[email protected]>
Signed-off-by: Brian Ezequiel Marchi <[email protected]>
Signed-off-by: Brian Ezequiel Marchi <[email protected]>
Signed-off-by: Brian Ezequiel Marchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments!
|
||
// Put the message into a queue to be processed by the middleware. | ||
// This call is non-blocking. | ||
pub_->publish(std::move(msg)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BMarchi if you check container output, you don't even have to publish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see why I don't have to publish, can you explain? The container process is the one who gets the output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean you can simply check the output the container generates on component load, no need for the component to generate extra output or even have any logic beyond these tests' purposes.
Signed-off-by: Brian Ezequiel Marchi <[email protected]>
Currently I'm dealing with the |
I wasn't able to find out the reason of why |
As the title says, this PR adds tests for the ros2component cli. It's lacking tests for the standalone verb and opensplice is returning a different code error that needs further investigation.
I wasn't able to separate all the verbs because the container is kept alive for every test case and I'm not sure if we can rerun the container each time a test is run.