Add docker support for Iron #68
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, but we aren't yet ready to add in Dockerfiles for this. We don't know which ROS releases we are going to support yet, and we don't know exactly what our deployment profile is going to be. So I think it is too early to put this in. For that reason, I'm going to mark this as a "Draft" for now, and we can revisit it later when we are closer to knowing what this all needs to look like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi this is a working Dockerfile. I tried to build this 2 dockerfiles and run them in two different machines but they cannot interact with each other with zenoh (they are connected in the same WiFi). Communication works in the same machine.