Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Introduce include-what-you-use into the build pipeline #323

Open
YuanYuYuan opened this issue Nov 22, 2024 · 1 comment
Open

[Feature] Introduce include-what-you-use into the build pipeline #323

YuanYuYuan opened this issue Nov 22, 2024 · 1 comment

Comments

@YuanYuYuan
Copy link
Contributor 

          I see. I'm unaware of this pattern. We usually trust the compiler in Rust. But when I studied this pattern and tried to apply the tool [include-what-you-use](https://github.com/include-what-you-use/include-what-you-use), I got many warnings. What do you think about introducing the check of include-what-you-use?

iwyu.txt

Originally posted by @YuanYuYuan in #276 (comment)
@YuanYuYuan
Copy link
Contributor Author

Furthermore, I think we need to wrap the ROS dependencies with brackets rather than quotes as include-what-you-use suggsted. And this way is also recommended in the ROS community. https://answers.ros.org/question/348742/double-quotes-vs-angled-brackets-for-rosrosh/

@YuanYuYuan YuanYuYuan mentioned this issue Nov 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@YuanYuYuan