Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor zenoh_config.hpp so we can reuse it in the router #102

Closed
clalancette opened this issue Jan 25, 2024 · 1 comment
Closed

Refactor zenoh_config.hpp so we can reuse it in the router #102

clalancette opened this issue Jan 25, 2024 · 1 comment
Labels
backlog Long-term improvement or addition

Comments

@clalancette
Copy link
Collaborator

We have code in https://github.com/ros2/rmw_zenoh/blob/rolling/rmw_zenoh_cpp/src/detail/zenoh_config.hpp and https://github.com/ros2/rmw_zenoh/blob/rolling/rmw_zenoh_cpp/src/detail/zenoh_config.cpp that is currently used to allow the user to configure the session configuration when using rmw_zenoh_cpp.

We should also use that code to be able to configure router configuration as well. That way, users will be able to launch the router locally with either the default config, or one they provide. The code probably needs some refactoring to be able to use it for that purpose.

This is a follow-up task from #101 .

@Yadunund
Copy link
Member

Yadunund commented Mar 4, 2024

Closed via #119

@Yadunund Yadunund closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Long-term improvement or addition
Projects
None yet
Development

No branches or pull requests

3 participants