From 42a82ab8b40c215c18eba2fc02f9569e89f0212e Mon Sep 17 00:00:00 2001 From: Chris Lalancette Date: Mon, 24 Jun 2024 14:46:08 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Yadu Signed-off-by: Chris Lalancette --- rmw_zenoh_cpp/src/detail/event.cpp | 2 +- rmw_zenoh_cpp/src/rmw_zenoh.cpp | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/rmw_zenoh_cpp/src/detail/event.cpp b/rmw_zenoh_cpp/src/detail/event.cpp index 5cf2cfb9..10d7a618 100644 --- a/rmw_zenoh_cpp/src/detail/event.cpp +++ b/rmw_zenoh_cpp/src/detail/event.cpp @@ -198,7 +198,7 @@ bool EventsManager::detach_condition_and_event_queue_is_empty(rmw_zenoh_event_ty "RMW Zenoh is not correctly configured to handle rmw_zenoh_event_type_t [%d]. " "Report this bug.", event_id); - return false; + return true; } std::lock_guard lock(event_condition_mutex_); diff --git a/rmw_zenoh_cpp/src/rmw_zenoh.cpp b/rmw_zenoh_cpp/src/rmw_zenoh.cpp index f1f6614d..4aa94d04 100644 --- a/rmw_zenoh_cpp/src/rmw_zenoh.cpp +++ b/rmw_zenoh_cpp/src/rmw_zenoh.cpp @@ -3289,7 +3289,6 @@ rmw_wait( // According to the documentation for rmw_wait in rmw.h, entries in the various arrays that have // *not* been triggered should be set to NULL - if (guard_conditions) { for (size_t i = 0; i < guard_conditions->guard_condition_count; ++i) { rmw_zenoh_cpp::GuardCondition * gc =