Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composition API #599

Open
wants to merge 20 commits into
base: rolling
Choose a base branch
from
Open

Composition API #599

wants to merge 20 commits into from

Commits on Mar 30, 2024

  1. Add the rclpy_component sub project 

    The project provide component container(special Node) and
component_manager

Signed-off-by: Zhen Ju <[email protected]>
    @crystaldust @sloretz
    crystaldust authored and sloretz committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    077707d View commit details
    Browse the repository at this point in the history

  2. Refer to ComponentManager from project rclpy_components 

    Signed-off-by: Zhen Ju <[email protected]>
    @crystaldust @sloretz
    crystaldust authored and sloretz committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    1f58c71 View commit details
    Browse the repository at this point in the history

  3. Set 'use_global_arguments' to False when creating node instance. 

    This is to get rid of the impact of global remapping rules on node
name, which will create nodes with duplicated names.

Remove *args in ComponentManager's constructor.

Signed-off-by: Zhen Ju <[email protected]>
    @crystaldust @sloretz
    crystaldust authored and sloretz committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    1bea84a View commit details
    Browse the repository at this point in the history

  4. Fixes & improments following the code review comments. 

    * Update the meta info in package.xml and setup.py
* Try-except executor.spin instead of main in executables
* Use f string to format infos
* Pass error message to response objectc instead of logging it
* Use node's logger instead of init a global one
* Call node.get_qualified_name() to assign response obj's full_node_name
* Other super tiny changes

Signed-off-by: Zhen Ju <[email protected]>
    @crystaldust @sloretz
    crystaldust authored and sloretz committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    9a43691 View commit details
    Browse the repository at this point in the history

  5. Add test cases for composition API. 

    Signed-off-by: Zhen Ju <[email protected]>
    @crystaldust @sloretz
    crystaldust authored and sloretz committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    875d84c View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2024

  1. Move test node into test subpackage 

    Signed-off-by: Shane Loretz <[email protected]>
    @sloretz
    sloretz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    874752b View commit details
    Browse the repository at this point in the history

  2. Remove unused test package marker file 

    Signed-off-by: Shane Loretz <[email protected]>
    @sloretz
    sloretz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    d23d9be View commit details
    Browse the repository at this point in the history

  3. Copyright not needed for empty file I think 

    Signed-off-by: Shane Loretz <[email protected]>
    @sloretz
    sloretz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    734d35e View commit details
    Browse the repository at this point in the history

  4. use non-deprecated underscore script_dir and install_scripts 

    Signed-off-by: Shane Loretz <[email protected]>
    @sloretz
    sloretz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    a839f77 View commit details
    Browse the repository at this point in the history

  5. Add __init__.py for test subpackage 

    Signed-off-by: Shane Loretz <[email protected]>
    @sloretz
    sloretz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    57092ea View commit details
    Browse the repository at this point in the history

  6. Consolidate unit tests into one 

    Signed-off-by: Shane Loretz <[email protected]>
    @sloretz
    sloretz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    96a2321 View commit details
    Browse the repository at this point in the history

  7. flake8 fixes 

    Signed-off-by: Shane Loretz <[email protected]>
    @sloretz
    sloretz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    85e6f60 View commit details
    Browse the repository at this point in the history

  8. Rename TestFoo to FooNode to avoid pytest trying to load tests from it 

    Signed-off-by: Shane Loretz <[email protected]>
    @sloretz
    sloretz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    c2921d7 View commit details
    Browse the repository at this point in the history

  9. Rewrite tests to use pytest and make them independent of each other 

    Signed-off-by: Shane Loretz <[email protected]>
    @sloretz
    sloretz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    ed26ff1 View commit details
    Browse the repository at this point in the history

  10. Misc flake8 fixes and bug fixes 

    Signed-off-by: Shane Loretz <[email protected]>
    @sloretz
    sloretz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    c4cf182 View commit details
    Browse the repository at this point in the history

  11. test_foo.py -> foo_node.py 

    Signed-off-by: Shane Loretz <[email protected]>
    @sloretz
    sloretz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    1e94788 View commit details
    Browse the repository at this point in the history

  12. Make node name and namespace be passed through remapping args 

    Signed-off-by: Shane Loretz <[email protected]>
    @sloretz
    sloretz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    a9dd0e7 View commit details
    Browse the repository at this point in the history

  13. Update author an maintainer entries 

    Signed-off-by: Shane Loretz <[email protected]>
    @sloretz
    sloretz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    8b1066f View commit details
    Browse the repository at this point in the history

  14. Update description for package 

    Signed-off-by: Shane Loretz <[email protected]>
    @sloretz
    sloretz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    dcb7da6 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Merge branch 'rolling' into composition-api-pr

    @mergify
    mergify[bot] authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    dc0c975 View commit details
    Browse the repository at this point in the history