rates_ vector out of channel order #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor provided Signed-off-by: Michael Anderson <[email protected]>
|
I'm honestly not sure that this is the correct fix. From what I can tell of the current code, it is actually possible (if non-intuitive) to configure the rates properly. You just need to call However, I'm not 100% sure of all of that. What I think we really need is an example/test that shows the problem that we are trying to solve, and the way we would solve it with the current code. Then we can consider whether this proposal solves it better. |
|
Sounds good! I can try adding a test to replicate #110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rates_vector out of channel order when user-specifiedRateConfigvector providedfixes #110