Update buffer_core.cpp #395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated fillOrWarnMessageForInvalidFrame log level to Debug for ros2#358.
|
We're past feature/API freeze for Galactic. While this is arguably a bug fix, it is also a major behavior change from all previous versions of ROS, so I don't think we should put this in now. Honestly, I'm not convinced that we should put this in at all. I'd much rather see this be throttled than reduce the severity; putting it at DEBUG level essentially guarantees that nobody will ever see it. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated fillOrWarnMessageForInvalidFrame log level to Debug for issue #358