-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Twist interpolator python bindings #643
Comments
For reference, I found this answer in answer.ros.org |
@tfoote mentioned this:
|
Aside: for longevity of the link here's the R.SE copy: https://robotics.stackexchange.com/questions/85274/tf-vs-tf2-lookuptwist-vs-lookup-transform This is pretty good timing. There's active work to reenable this by extending the Velocity message here: ros2/common_interfaces#233 so that we can have fully encoded semantics. With that extra information we can extend this logic And add a doTransform method for tf2_geometry_msgs here: https://github.com/ros2/geometry2/blob/rolling/tf2_geometry_msgs/include/tf2_geometry_msgs/tf2_geometry_msgs.hpp The old implementatoin can be found here: https://github.com/ros/geometry/blob/73185068daaca224486bda84ed240fbfe86df80b/tf/src/tf.cpp#L306-L342 Note that it will need the new datatype, and also to have the extra argument for duration over which to average: https://github.com/ros/geometry/blob/73185068daaca224486bda84ed240fbfe86df80b/tf/include/tf/tf.h#L145 because it queries for the velocity value inside. So that might need an extension to the templated
|
Related PR #646 |
The twist interpolator is commented out in python bindings. We will need it for our work and want to ensure it gets added in the python layer.
geometry2/tf2_py/src/tf2_py.cpp
Line 1061 in 1621942
geometry2/tf2_py/src/tf2_py.cpp
Line 631 in 1621942
Bug report
Required Info:
Steps to reproduce issue
Expected behavior
Actual behavior
Additional information
Feature request
Feature description
Implementation considerations
The text was updated successfully, but these errors were encountered: