Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[allocator_tutorial] Adding polymorphic allocators #650

Open
AliAshkaniNia opened this issue Sep 28, 2023 · 1 comment
Open

[allocator_tutorial] Adding polymorphic allocators #650

AliAshkaniNia opened this issue Sep 28, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@AliAshkaniNia
Copy link
Contributor

I recently reviewed the Implementing a custom memory allocator section and wanted to provide a friendly suggestion. While the MyAllocator implementation works well for C++11, ROS 2 also supports C++17 polymorphic memory allocators which offer a simpler alternative. I believe adding examples using the polymorphic allocators could make this section more beginner-friendly.

I am prepared to provide a minimum working example and make the necessary modifications to the documentation. Please let me know if there are any particular reasons for not including this approach in the tutorial already, or if you think it would be valuable to add as an additional option.

@clalancette
Copy link
Contributor

I'm not all familiar with the polymorphic allocators, but if they end up being a simpler alternative I think that would be welcome. If you'd like to submit a PR with that change, we are happy to take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants