Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No symbols are exported for urdfdom_model_state and urdfdom_sensor libraries #42

Open
traversaro opened this issue Aug 5, 2014 · 2 comments
Labels

Comments

@traversaro
Copy link
Contributor

traversaro commented Aug 5, 2014

Apparently during the configuration this two libraries (urdfdom_model_state, urdfdom_sensor) are created, but no symbol from any of this two libraries is properly exported in https://github.com/ros/urdfdom/blob/master/urdf_parser/include/urdf_parser/urdf_parser.h .

On Windows this causes an error when using the urdfdom library.
I guess there are three possible solutions:

  • Properly expose the symbols defined in this two libraries.
  • Remove these libraries.
  • Add the source code of this libraries to the urdf_model (but without exposing the symbols this will be unused code).
@sloretz
Copy link
Contributor

sloretz commented Aug 10, 2017

Where are urdf_model_state and urdfdom_sensor used?

urdf_model_state.cpp defines a function urdf::parseModelState, but it's not used in this repo and there are no headers for it. Similar story for urdf_sensor.cpp.

If they are not used and no one else can use them because there is no header, it seems like option 2 (removing the libraries) is the way to go.

@traversaro
Copy link
Contributor Author

I don't remember the status of this issue or if the upstream version of urdfdom is compiling on Windows/MSVC, but I agree that removing these libraries is the way to go in any case.

@sloretz sloretz added the bug label Apr 13, 2018
Karsten1987 pushed a commit to Karsten1987/urdfdom that referenced this issue Nov 15, 2018
* Use stringstream instead of stod to work around locale issues.

Signed-off-by: Chris Lalancette <[email protected]>

* Use imbue to always use the "classic" locale.

Signed-off-by: Chris Lalancette <[email protected]>

* Make a strToDouble facility in the utils.h header.

This will be useful elsewhere (i.e. urdfdom).

Signed-off-by: Chris Lalancette <[email protected]>

* Add some additional includes.

Signed-off-by: Chris Lalancette <[email protected]>

* Add in an actual error message to the strToDouble throw.

Signed-off-by: Chris Lalancette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants