Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to specify namespace of generated type of .msg/.srv? #93

Open
kohei306 opened this issue Oct 10, 2020 · 4 comments
Open

Feature to specify namespace of generated type of .msg/.srv? #93

kohei306 opened this issue Oct 10, 2020 · 4 comments

Comments

@kohei306
Copy link

It would be great if we can have flexibility to specify namespace for the generated message/service type. This helps not to break old recording after refactoring package structure and changing package name or separate it out to new package (This means name space changes).

@dirk-thomas
Copy link
Member

Since the already released ROS distro Noetic is planned to be the last ROS 1 distribution there is no plan to implement new features like this. The straight forward workaround for your use case seems to be to keep the previous package name around.

@kohei306
Copy link
Author

Since the already released ROS distro Noetic is planned to be the last ROS 1 distribution there is no plan to implement new features like this. The straight forward workaround for your use case seems to be to keep the previous package name around.

I have made PRs for genmsg & gencpp.

#94
ros/gencpp#50

@dirk-thomas
Copy link
Member

I still don't think that this is a change we want to land in an already released distro. Also it opens the door to colliding files coming from different Debian packages.

Anyway the new maintainer of this repo @mjcarroll might want to comment on this.

@Eddylib
Copy link

Eddylib commented Nov 23, 2020

It would be greate if the namespace can be inferenced by the structure of message defination dir.
for example:
directory structure

PackageA
    |---msg
         |---dir1
                |---message1.msg
         |---dir2
                |---message2.msg

output files:
devel/include/PackageA/dir1/message1.msg
devel/include/PackageA/dir2/message2.msg

usercode:

#include <PackageA/dir1/message1.h>
#include <PackageA/dir2/message2.h>
using PackageA::dir1::message1;
using PackageA::dir2::message2;

It will be great for integrate common messages into one package to reduce cycle dependence without corrupting the original structure of project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants