<build_type> does not default to catkin if a false condition is present

[Timple]

To reproduce: add the line <build_type condition="$ROS_VERSION == 2">ament_cmake</build_type> to a ROS1 package like stereo_msgs.

catkin_make_isolated will fail now.

Expected behavior: The complete line should be ignored because of the condition and the default of catkin should be used.

---

Interesting detail: This works:

<build_type condition="$ROS_VERSION == 1">catkin</build_type>
<build_type condition="$ROS_VERSION == 2">ament_cmake</build_type>

And this doesn't:

<build_type condition="$ROS_VERSION == 2">ament_cmake</build_type>
<build_type condition="$ROS_VERSION == 1">catkin</build_type>

[Gonzalo-Mier]

For the record, the error that happens is:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~  traversing 1 packages in topological order:
~~  - package_name (unknown)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: Packages with unknown build types exist
Can not build workspace with packages of unknown build_type

[MatthijsBurgh]

I think the root cause is in catkin_pkg
https://github.com/ros-infrastructure/catkin_pkg/blob/2b05c0fbc4f9e3362bc05ac16880f651af7b6b67/src/catkin_pkg/package.py#L150-L167

[ivanpauno]

IIUC, this code block here should be updated to use get_build_type().

Contributions are welcomed, feel free to tag me as a reviewer.

[ros-discourse]

This issue has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/automatic-deployment-of-ros2-based-system-to-remote-devices-dual-copy-or-containers/33884/42