Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compressed_image_transport: Compression/decompression functions as stand-alone lib? #49

Open
airballking opened this issue Jan 8, 2020 · 3 comments

Comments

@airballking
Copy link

Hi,

I have an application in which I need the beef of this function as a stand-alone function without the plugin machinery around it. Basically everything but the last call to the user-callback. Instead, I'd return the decoded image pointer.

My first impulse was to just copy-and-paste it out, but then I realized that others might be interested in such a function, too. Hence, my question: Would it be meaningful to have this decompression code (and its corresponding compression code) in separate functions in a stand-alone lib? If yes, would you be will to review and merge a pull request? If yes, I'd be happy to provide it. :)

Cheers,
Georg.

@airballking
Copy link
Author

@dgossow Would you be interested in such a pull request?

@dgossow
Copy link
Contributor

dgossow commented Jan 17, 2020

sounds like a reasonable suggestion. I will review the PR if you want to do the refactoring.

@airballking
Copy link
Author

Great. Then, I'll go ahead, and work on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants