Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

update package and fix build #10

Closed
wants to merge 1 commit into from
Closed

update package and fix build #10

wants to merge 1 commit into from

Conversation

acxz
Copy link
Member

@acxz acxz commented Dec 24, 2019

resolves #9

@acxz
Copy link
Member Author

acxz commented Dec 24, 2019

Note: This introduces python2 but fixes the build.

@bionade24
Copy link
Member

Looking into it, don't like the python2 deps. We probably kicked them out at some qt package.

@acxz
Copy link
Member Author

acxz commented Jan 3, 2020

I don't like them either, but I hate people not using ROS on Arch more. We can try to resolve the issue while the package still works, instead of have Arch users wait for us.

@jwhendy
Copy link
Contributor

jwhendy commented Jan 3, 2020

See my latest comment on #9 for my analysis. tl;dr: I think we have a python3 compatible way forward that does not require bringing back python2 deps.

@bionade24
Copy link
Member

Thanks @jwhendy for the research. I now patched ros-melodic-qt-binding, so problems should be solved soon.

@bionade24 bionade24 closed this Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The sip directory for PyQt5 could not be located with Python3
3 participants