-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more information to the generated pull requests #116
Comments
That's a good point. Currently, we just display the packages and the distro that's affected. I could see the version changes as a minimal first step for resolving this.
This would also be a super useful feature, and shouldn't be too hard to implement. Thanks for the feedback, @tfoote. |
Looking at ros/ros-overlay#395
One concrete request is to add the superflore version executed and remove the full path ( |
Ya, that's a good idea. I'm not sure why it expanded, to be honest -- it just pulls from |
@tfoote Do you think this can be closed? Just cleaning up the backlog. |
Before closing this out I'd like to see a little bit more so that the message is understandable for someone who comes across the PR but is not familiar with superflore. There should be enough info for them to find the documentation and read about what's happening so that they could effectively help to review it. Links out to other documentation and an explanation. |
When reviewing the pull requests it would be great to have as much information about where the content came from as possible.
For example this PR: ros/ros-overlay#337 I'd like to know what changes are being integrated into this repo and why?
Adding as much information as possible would be great. In particular things like the command arguments and options used to invoke superflore. As well as any environment and relevant urls for repositories being operated on, the rosdistro etc. Optimally I would be able to completely reproduce the PR with the contents of the description if I wanted to test or try something a little different.
The text was updated successfully, but these errors were encountered: