Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce notion of "experimental" build types. #702

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Introduce notion of "experimental" build types. #702

wants to merge 3 commits into from

Commits on May 26, 2023

  1. Introduce notion of an "experimental" build type. 

    When per build type templates were introduced for ROS 2 support, little
thought was given to how the number of build types might expand in the
future. I think that there's good fodder for a rethink of the build type
handling in general, but in the meantime I would like to introduce this
concept and a small warning to signify the possibility that these new
build types are outside the focus of the core infrastructure team.

The initial criteria for a build type being "experimental" is that it's
novel.
Criteria for graduating from an experimental build type to normal one is
not currently settled.
    @nuclearsandwich
    nuclearsandwich committed May 26, 2023
    Configuration menu
    Copy the full SHA
    cc30403 View commit details
    Browse the repository at this point in the history

  2. Prompt and stop on experimental build types. 

    This addition pauses generation on the experimental build type and
prompts the user to continue each time.

Defaulting to yes is intentional.
    @nuclearsandwich
    nuclearsandwich committed May 26, 2023
    Configuration menu
    Copy the full SHA
    69e7cac View commit details
    Browse the repository at this point in the history

  3. Use BLOOM_ALLOW_EXPERIMENTAL_BUILD_TYPES to skip prompt.

    @nuclearsandwich
    nuclearsandwich committed May 26, 2023
    Configuration menu
    Copy the full SHA
    e7519e4 View commit details
    Browse the repository at this point in the history