Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move stomp_core to its own repository and make a pure cmake? #6

Open
Levi-Armstrong opened this issue Jul 1, 2019 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@Levi-Armstrong
Copy link
Member

Any objection to moving the stomp_core package to its own repository and making it a pure cmake?

@jrgnicho
Copy link
Member

jrgnicho commented Aug 5, 2019

I'm not opposed to it

@jrgnicho jrgnicho added wrid20 World ROS-Industrial Day 2020 enhancement New feature or request labels Jul 6, 2020
@jrgnicho
Copy link
Member

jrgnicho commented Jul 6, 2020

Instead of creating a whole new repo for stomp_core we could just make that into a pure cmake package and modify the CMakeList.txt in stomp_moveit to build only in ROS 1 and get ignored in ROS2 as done here. Eventually we could create a stomp_moveit2 package if necessary

@gavanderhoorn gavanderhoorn removed the wrid20 World ROS-Industrial Day 2020 label Sep 30, 2021
@Levi-Armstrong
Copy link
Member Author

@gavanderhoorn Correct me if I am wrong, but the decided approach was that ROS1 and ROS2 should go in separated repositories?

@Levi-Armstrong
Copy link
Member Author

In addition, I plan to create Tesseract implementation which does not make sense to have everything in this repository. Also, I believe stomp_moveit should most likely go under the MoveIt organization or directly in MoveIt but the STOMP Core should remain under ROS Industrial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants