demo hardware compatibility and QoL updates #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Yolnan
commented
Mar 13, 2024
•
Yolnan
commented
- add entrypoint for snp_automate_2022 docker container
- remove humble and rolling from CI, addresses Drop CI for Humble and Foxy #5
- add compatibility for apt install realsense driver
marip8
reviewed
Mar 13, 2024
marip8
reviewed
Mar 13, 2024
launch/start.launch.xml
Outdated
| <arg name="color_width" value="640"/> | ||
| <arg name="color_height" value="360"/> | ||
| <arg name="color_fps" value="90.0"/> | ||
| <arg name="rgb_camera.profile" value="640x360x90"/> |
There was a problem hiding this comment.
Does this actually work? @DavidSpielman tried this with a real camera and it complained about the resolution dimensions. I think it wanted "640x480x30"
There was a problem hiding this comment.
It seems to achieve 640x360 on the D455 cameras mounted on the demos. I guess it isn't valid on the D435i? I'll lower the FPS down to 30.
marip8
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.