Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new button action does not prompt the user to save before clearing. #99

Open
Levi-Armstrong opened this issue May 12, 2016 · 6 comments

Comments

@Levi-Armstrong
Copy link
Contributor

If you load a robot and make changes, then click the new button the model is erased. If changes are made it should probably notify the user with the option to save before clearing.

@gavanderhoorn
Copy link
Member

Thanks for the report.

Possible approach for a fix: check the urdf_tree_->unsavedChanges variable in void URDFEditor::on_action_New_triggered() and invoke the appropriate 'save before exit' logic if required, instead of unconditionally clearing everything.

@AndyZe
Copy link
Contributor

AndyZe commented May 17, 2016

@gavanderhoorn @phvass Can you assign this one to me please?

@AndyZe
Copy link
Contributor

AndyZe commented May 26, 2016

I just realized this should include checking for changes before "Open," too

@AndyZe
Copy link
Contributor

AndyZe commented May 26, 2016

Making notes to myself: I couldn't build the m1 branch until "sudo apt-get install liboce-ocaf-dev"

@AndyZe
Copy link
Contributor

AndyZe commented May 26, 2016

Changes to some properties aren't being detected anymore.

@gavanderhoorn
Copy link
Member

Making notes to myself: I couldn't build the m1 branch until "sudo apt-get install liboce-ocaf-dev"

Yes. That is documented on the wiki, see wiki/Development, and more specifically, the wiki/OCE-packages page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants